content/browser/speech/speech_recognition_dispatcher_host.cc - Issue 10407120: Moving tray icon and notification balloon for background speech recognition sessions to ChromeSpeec…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/speech/speech_recognition_dispatcher_host.cc

Issue 10407120: Moving tray icon and notification balloon for background speech recognition sessions to ChromeSpeec… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Turned context_name to string (instead of string16) Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/speech/chrome_speech_recognition_manager_delegate.h ('K') | « chrome/common/pref_names.cc ('k') | content/public/browser/speech_recognition_session_context.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/speech/speech_recognition_dispatcher_host.cc

diff --git a/content/browser/speech/speech_recognition_dispatcher_host.cc b/content/browser/speech/speech_recognition_dispatcher_host.cc

index 3044cff13c5853a48667dda2b8257095a3cfcd5e..08ac1fb0474deef4d4fd94c4f0526bed0637b76a 100644

--- a/content/browser/speech/speech_recognition_dispatcher_host.cc

+++ b/content/browser/speech/speech_recognition_dispatcher_host.cc

@@ -7,12 +7,14 @@

#include "base/bind.h"

#include "base/command_line.h"

#include "base/lazy_instance.h"

+#include "base/utf_string_conversions.h"

hans 2012/06/11 15:52:15 i can't see where this is used..

Primiano Tucci (use gerrit) 2012/06/11 17:03:22 Right, it was part some experiments later aborted.

#include "content/common/speech_recognition_messages.h"

#include "content/public/browser/speech_recognition_manager.h"

#include "content/public/browser/speech_recognition_preferences.h"

#include "content/public/browser/speech_recognition_session_config.h"

#include "content/public/browser/speech_recognition_session_context.h"

#include "content/public/common/content_switches.h"

+#include "googleurl/src/gurl.h"

using content::SpeechRecognitionManager;

using content::SpeechRecognitionSessionConfig;

@@ -73,9 +75,11 @@ void SpeechRecognitionDispatcherHost::OnStartRequest(

const SpeechRecognitionHostMsg_StartRequest_Params& params) {

SpeechRecognitionSessionContext context;

+ context.context_name = GURL(params.origin_url).spec();

context.render_process_id = render_process_id_;

context.render_view_id = params.render_view_id;

context.request_id = params.request_id;

+ context.requested_by_page_element = false;

SpeechRecognitionSessionConfig config;

config.is_one_shot = params.is_one_shot;