Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: pylib/gyp/xcode_emulation.py

Issue 10407108: ninja windows: support precompiled headers (Closed) Base URL: https://gyp.googlecode.com/svn/trunk
Patch Set: no-op for linux, simplify? extension handling Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pylib/gyp/xcode_emulation.py
diff --git a/pylib/gyp/xcode_emulation.py b/pylib/gyp/xcode_emulation.py
index 9ed98d5fab53fc44def0cb0474057bdd948ec9a1..7fd795034ec5354d84696ecd52bb1728fa412264 100644
--- a/pylib/gyp/xcode_emulation.py
+++ b/pylib/gyp/xcode_emulation.py
@@ -752,17 +752,17 @@ class MacPrefixHeader(object):
result.append((source, obj, self._Gch(lang)))
return result
- def GetGchBuildCommands(self):
- """Returns [(path_to_gch, language_flag, language, header)].
+ def GetPchBuildCommands(self):
+ """Returns [(path_to_gch, language_flag, language, header, extra_vars)].
|path_to_gch| and |header| are relative to the build directory.
"""
if not self.header or not self.compile_headers:
return []
return [
- (self._Gch('c'), '-x c-header', 'c', self.header),
- (self._Gch('cc'), '-x c++-header', 'cc', self.header),
- (self._Gch('m'), '-x objective-c-header', 'm', self.header),
- (self._Gch('mm'), '-x objective-c++-header', 'mm', self.header),
+ (self._Gch('c'), '-x c-header', 'c', self.header, []),
+ (self._Gch('cc'), '-x c++-header', 'cc', self.header, []),
+ (self._Gch('m'), '-x objective-c-header', 'm', self.header, []),
+ (self._Gch('mm'), '-x objective-c++-header', 'mm', self.header, []),
]

Powered by Google App Engine
This is Rietveld 408576698