Improve error messaging of webRequest API in case of conflicts

chrome/browser/extensions/extension_warning_badge_service_unittest.cc

Index: chrome/browser/extensions/extension_warning_badge_service_unittest.cc
diff --git a/chrome/browser/extensions/extension_warning_badge_service_unittest.cc b/chrome/browser/extensions/extension_warning_badge_service_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..44611482e5496af0257a4e005f0904035d2f0d94
--- /dev/null
+++ b/chrome/browser/extensions/extension_warning_badge_service_unittest.cc
@@ -0,0 +1,97 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/extension_warning_badge_service.h"
+
+#include "chrome/app/chrome_command_ids.h"
+#include "chrome/browser/extensions/extension_warning_set.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/ui/global_error/global_error_service.h"
+#include "chrome/browser/ui/global_error/global_error_service_factory.h"
+#include "chrome/test/base/testing_profile.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace extensions {
+
+namespace {
+
+class TestExtensionWarningSet : public ExtensionWarningSet {
+ public:
+  explicit TestExtensionWarningSet(Profile* profile)
+      : ExtensionWarningSet(profile) {
+  }
+  virtual ~TestExtensionWarningSet() {}
+
+  void AddWarning(const ExtensionWarning& warning) {
+    std::set<ExtensionWarning> warnings;
+    warnings.insert(warning);
+    AddWarnings(warnings);
+  }
+};
+
+class TestExtensionWarningBadgeService : public ExtensionWarningBadgeService {
+ public:
+  TestExtensionWarningBadgeService(Profile* profile,
+                                   ExtensionWarningSet* warnings)
+      : ExtensionWarningBadgeService(profile), warnings_(warnings) {}
+  virtual ~TestExtensionWarningBadgeService() {}
+
+  virtual const std::set<ExtensionWarning>& GetCurrentWarnings() const {
+    return warnings_->warnings();
+  }
+
+ private:
+  ExtensionWarningSet* warnings_;
+};
+
+bool HasBadge(Profile* profile) {
+  GlobalErrorService* service =
+      GlobalErrorServiceFactory::GetForProfile(profile);
+  return service->GetGlobalErrorByMenuItemCommandID(IDC_EXTENSION_ERRORS) !=
+      NULL;
+}
+
+const char* ext1_id = "extension1";
+const char* ext2_id = "extension2";
+const ExtensionWarning::WarningType warning_1 =
+    ExtensionWarning::kNetworkDelay;
+const ExtensionWarning::WarningType warning_2 =
+    ExtensionWarning::kNetworkConflict;
+
+}  // namespace
+
+// Check that no badge appears if it has been suppressed for a specific
+// warning.
+TEST(ExtensionWarningBadgeServiceTest, SuppressBadgeForCurrentWarnings) {
+  TestingProfile profile;
+  TestExtensionWarningSet warnings(&profile);
+  TestExtensionWarningBadgeService badge_service(&profile, &warnings);
+  warnings.AddObserver(&badge_service);
+
+  // Insert first warning.
+  warnings.AddWarning(ExtensionWarning::CreateNetworkDelayWarning(ext1_id));
+  EXPECT_TRUE(HasBadge(&profile));
+
+  // Suppress first warning.
+  badge_service.SuppressCurrentWarnings();
+  EXPECT_FALSE(HasBadge(&profile));
+
+  // Simulate deinstallation of extension.
+  std::set<ExtensionWarning::WarningType> to_clear;
+  warnings.GetWarningTypesAffectingExtension(ext1_id, &to_clear);
+  warnings.ClearWarnings(to_clear);
+  EXPECT_FALSE(HasBadge(&profile));
+
+  // Set first warning again and verify that not badge is shown this time.
+  warnings.AddWarning(ExtensionWarning::CreateNetworkDelayWarning(ext1_id));
+  EXPECT_FALSE(HasBadge(&profile));
+
+  // Set second warning and verify that it shows a badge.
+  warnings.AddWarning(ExtensionWarning::CreateNetworkConflictWarning(ext2_id));
+  EXPECT_TRUE(HasBadge(&profile));
+
+  warnings.RemoveObserver(&badge_service);
+}
+
+}   // namespace extensions