Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Issue 10407070: Warm up Mac video decoding APIs before enabling sandbox (Closed)

Created:
8 years, 7 months ago by sail
Modified:
7 years, 10 months ago
CC:
chromium-reviews, jochen+watch-content_chromium.org, jam, apatrick_chromium, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Warm up Mac video decoding APIs before enabling sandbox This CL warms up the Mac hardware video decoding APIs before the GPU sandbox is enabled. On my MacBook Pro laptop this takes 450 miliseconds after a fresh reboot and 130 miliseconds afterwards. BUG=127414 TEST=

Patch Set 1 #

Total comments: 4

Patch Set 2 : address review comments #

Patch Set 3 : rebase #

Total comments: 10

Patch Set 4 : address review comments #

Total comments: 9

Patch Set 5 : address review comments #

Patch Set 6 : address review comments #

Patch Set 7 : remove check #

Patch Set 8 : fix --no-sandbox #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -0 lines) Patch
M content/common/gpu/media/mac_video_decode_accelerator.h View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M content/common/gpu/media/mac_video_decode_accelerator.mm View 1 2 3 4 5 6 7 3 chunks +41 lines, -0 lines 0 comments Download
M content/common/gpu/media/video_decode_accelerator_unittest.cc View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/sandbox_mac.mm View 2 5 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
sail
8 years, 7 months ago (2012-05-21 20:00:53 UTC) #1
Nico
lgtm I don't know if we have gpu process startup time perf tests.
8 years, 7 months ago (2012-05-21 20:13:51 UTC) #2
Robert Sesek
LGTM
8 years, 7 months ago (2012-05-21 20:20:57 UTC) #3
Ami GONE FROM CHROMIUM
Please note dependent CLs. https://chromiumcodereview.appspot.com/10407070/diff/1/content/common/gpu/media/mac_video_decode_accelerator.h File content/common/gpu/media/mac_video_decode_accelerator.h (right): https://chromiumcodereview.appspot.com/10407070/diff/1/content/common/gpu/media/mac_video_decode_accelerator.h#newcode46 content/common/gpu/media/mac_video_decode_accelerator.h:46: // Warm up the video ...
8 years, 7 months ago (2012-05-21 20:23:49 UTC) #4
sail
https://chromiumcodereview.appspot.com/10407070/diff/1/content/common/gpu/media/mac_video_decode_accelerator.h File content/common/gpu/media/mac_video_decode_accelerator.h (right): https://chromiumcodereview.appspot.com/10407070/diff/1/content/common/gpu/media/mac_video_decode_accelerator.h#newcode46 content/common/gpu/media/mac_video_decode_accelerator.h:46: // Warm up the video decoding API. On 2012/05/21 ...
8 years, 7 months ago (2012-05-24 00:04:08 UTC) #5
sail
Addressed review comments.
8 years, 7 months ago (2012-05-24 00:08:11 UTC) #6
Ami GONE FROM CHROMIUM
CL basically lgtm. See a few nits below. Of course this can't land until the ...
8 years, 7 months ago (2012-05-24 04:41:25 UTC) #7
sail
http://codereview.chromium.org/10407070/diff/8003/content/common/gpu/media/mac_video_decode_accelerator.mm File content/common/gpu/media/mac_video_decode_accelerator.mm (right): http://codereview.chromium.org/10407070/diff/8003/content/common/gpu/media/mac_video_decode_accelerator.mm#newcode47 content/common/gpu/media/mac_video_decode_accelerator.mm:47: bool MacVideoDecodeAccelerator::pre_sandbox_init_done_ = false; On 2012/05/24 04:41:26, Ami Fischman ...
8 years, 6 months ago (2012-05-29 04:07:02 UTC) #8
Ami GONE FROM CHROMIUM
http://codereview.chromium.org/10407070/diff/19002/content/common/gpu/media/mac_video_decode_accelerator.mm File content/common/gpu/media/mac_video_decode_accelerator.mm (right): http://codereview.chromium.org/10407070/diff/19002/content/common/gpu/media/mac_video_decode_accelerator.mm#newcode235 content/common/gpu/media/mac_video_decode_accelerator.mm:235: // is invalid and should be changed. If you're ...
8 years, 6 months ago (2012-05-29 04:15:47 UTC) #9
sail
http://codereview.chromium.org/10407070/diff/19002/content/common/gpu/media/mac_video_decode_accelerator.mm File content/common/gpu/media/mac_video_decode_accelerator.mm (right): http://codereview.chromium.org/10407070/diff/19002/content/common/gpu/media/mac_video_decode_accelerator.mm#newcode235 content/common/gpu/media/mac_video_decode_accelerator.mm:235: // is invalid and should be changed. On 2012/05/29 ...
8 years, 6 months ago (2012-05-29 04:31:44 UTC) #10
Ami GONE FROM CHROMIUM
http://codereview.chromium.org/10407070/diff/19002/content/common/gpu/media/mac_video_decode_accelerator.mm File content/common/gpu/media/mac_video_decode_accelerator.mm (right): http://codereview.chromium.org/10407070/diff/19002/content/common/gpu/media/mac_video_decode_accelerator.mm#newcode235 content/common/gpu/media/mac_video_decode_accelerator.mm:235: // is invalid and should be changed. On 2012/05/29 ...
8 years, 6 months ago (2012-05-29 04:42:00 UTC) #11
sail
Addressed review comments and rebased. http://codereview.chromium.org/10407070/diff/19002/content/common/gpu/media/mac_video_decode_accelerator.mm File content/common/gpu/media/mac_video_decode_accelerator.mm (right): http://codereview.chromium.org/10407070/diff/19002/content/common/gpu/media/mac_video_decode_accelerator.mm#newcode235 content/common/gpu/media/mac_video_decode_accelerator.mm:235: // is invalid and ...
8 years, 6 months ago (2012-05-30 04:17:08 UTC) #12
sail
http://codereview.chromium.org/10407070/diff/19002/content/common/gpu/media/mac_video_decode_accelerator.mm File content/common/gpu/media/mac_video_decode_accelerator.mm (right): http://codereview.chromium.org/10407070/diff/19002/content/common/gpu/media/mac_video_decode_accelerator.mm#newcode235 content/common/gpu/media/mac_video_decode_accelerator.mm:235: // is invalid and should be changed. On 2012/05/30 ...
8 years, 6 months ago (2012-05-30 19:28:24 UTC) #13
Ami GONE FROM CHROMIUM
sail: ping?
8 years, 5 months ago (2012-07-23 22:20:13 UTC) #14
sail
8 years, 5 months ago (2012-07-23 22:25:11 UTC) #15
On 2012/07/23 22:20:13, Ami Fischman wrote:
> sail: ping?

Sorry for not updating this CL sooner.
Currently I'm working on bug 127499 (valgrind reports leaks in mac video
decoding code). I need to fix this before landing this CL.

I've had trouble getting valgrind setup on my Mac. I'm hoping to have this
resolved soon. Thanks!

Powered by Google App Engine
This is Rietveld 408576698