Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: tools/clang/plugins/tests/base_refcounted.txt

Issue 10407057: Optionally check base classes for refcounting issues (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge into one AST pass Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 In file included from base_refcounted.cpp:5: 1 In file included from base_refcounted.cpp:5:
2 ./base_refcounted.h:45:3: warning: [chromium-style] Classes that are ref-counted should not have public destructors. 2 ./base_refcounted.h:47:3: warning: [chromium-style] Classes that are ref-counted should not have public destructors.
3 ~PublicRefCountedDtorInHeader() {} 3 ~PublicRefCountedDtorInHeader() {}
4 ^ 4 ^
5 ./base_refcounted.h:57:3: warning: [chromium-style] Classes that are ref-counted should not have public destructors. 5 ./base_refcounted.h:44:7: note: [chromium-style] 'PublicRefCountedDtorInHeader' inherits from 'base::RefCounted<PublicRefCountedDtorInHeader>' here
6 : public base::RefCounted<PublicRefCountedDtorInHeader> {
7 ^
8 ./base_refcounted.h:59:3: warning: [chromium-style] Classes that are ref-counted should not have public destructors.
6 ~PublicRefCountedThreadSafeDtorInHeader() {} 9 ~PublicRefCountedThreadSafeDtorInHeader() {}
7 ^ 10 ^
8 ./base_refcounted.h:94:3: warning: [chromium-style] Classes that are ref-counted should not have public destructors. 11 ./base_refcounted.h:55:7: note: [chromium-style] 'PublicRefCountedThreadSafeDtor InHeader' inherits from 'base::RefCountedThreadSafe<PublicRefCountedThreadSafeDt orInHeader>' here
12 : public base::RefCountedThreadSafe<
13 ^
14 ./base_refcounted.h:96:3: warning: [chromium-style] Classes that are ref-counted should not have public destructors.
9 ~DerivedProtectedToPublicInHeader() {} 15 ~DerivedProtectedToPublicInHeader() {}
10 ^ 16 ^
11 ./base_refcounted.h:99:1: warning: [chromium-style] Classes that are ref-counted should have explicit destructors that are protected or private. 17 ./base_refcounted.h:93:7: note: [chromium-style] 'DerivedProtectedToPublicInHead er' inherits from 'ProtectedRefCountedDtorInHeader' here
18 : public ProtectedRefCountedDtorInHeader {
19 ^
20 ./base_refcounted.h:68:7: note: [chromium-style] 'ProtectedRefCountedDtorInHeade r' inherits from 'base::RefCounted<ProtectedRefCountedDtorInHeader>' here
21 : public base::RefCounted<ProtectedRefCountedDtorInHeader> {
22 ^
23 ./base_refcounted.h:101:7: warning: [chromium-style] Classes that are ref-counte d should have explicit destructors that are declared protected or private.
12 class ImplicitDerivedProtectedToPublicInHeader 24 class ImplicitDerivedProtectedToPublicInHeader
13 ^ 25 ^
26 ./base_refcounted.h:102:7: note: [chromium-style] 'ImplicitDerivedProtectedToPub licInHeader' inherits from 'ProtectedRefCountedDtorInHeader' here
27 : public ProtectedRefCountedDtorInHeader {
28 ^
29 ./base_refcounted.h:68:7: note: [chromium-style] 'ProtectedRefCountedDtorInHeade r' inherits from 'base::RefCounted<ProtectedRefCountedDtorInHeader>' here
30 : public base::RefCounted<ProtectedRefCountedDtorInHeader> {
31 ^
14 base_refcounted.cpp:16:3: warning: [chromium-style] Classes that are ref-counted should not have public destructors. 32 base_refcounted.cpp:16:3: warning: [chromium-style] Classes that are ref-counted should not have public destructors.
15 ~AnonymousDerivedProtectedToPublicInImpl() {} 33 ~AnonymousDerivedProtectedToPublicInImpl() {}
16 ^ 34 ^
35 base_refcounted.cpp:13:7: note: [chromium-style] 'AnonymousDerivedProtectedToPub licInImpl' inherits from 'ProtectedRefCountedDtorInHeader' here
36 : public ProtectedRefCountedDtorInHeader {
37 ^
38 ./base_refcounted.h:68:7: note: [chromium-style] 'ProtectedRefCountedDtorInHeade r' inherits from 'base::RefCounted<ProtectedRefCountedDtorInHeader>' here
39 : public base::RefCounted<ProtectedRefCountedDtorInHeader> {
40 ^
17 base_refcounted.cpp:26:3: warning: [chromium-style] Classes that are ref-counted should not have public destructors. 41 base_refcounted.cpp:26:3: warning: [chromium-style] Classes that are ref-counted should not have public destructors.
18 ~PublicRefCountedDtorInImpl() {} 42 ~PublicRefCountedDtorInImpl() {}
19 ^ 43 ^
44 base_refcounted.cpp:23:7: note: [chromium-style] 'PublicRefCountedDtorInImpl' in herits from 'base::RefCounted<PublicRefCountedDtorInImpl>' here
45 : public base::RefCounted<PublicRefCountedDtorInImpl> {
46 ^
20 base_refcounted.cpp:52:3: warning: [chromium-style] Classes that are ref-counted should not have public destructors. 47 base_refcounted.cpp:52:3: warning: [chromium-style] Classes that are ref-counted should not have public destructors.
21 ~UnsafeTypedefChainInImpl() {} 48 ~UnsafeTypedefChainInImpl() {}
22 ^ 49 ^
50 base_refcounted.cpp:49:34: note: [chromium-style] 'UnsafeTypedefChainInImpl' inh erits from 'Baz::MyLocalTypedef' (aka 'RefCounted<Foo::BarInterface>') here
51 class UnsafeTypedefChainInImpl : public Baz::MyLocalTypedef {
52 ^
23 7 warnings generated. 53 7 warnings generated.
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698