Copy VC CRT DLLs for component build even when VS is not installed.

chrome/tools/build/win/create_installer_archive.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Script to create Chrome Installer archive.
 
   This script is used to create an archive of all the files required for a
   Chrome install in appropriate directory structure. It reads chrome.release
   file as input, creates chrome.7z archive, compresses setup.exe and
@@ skipping 317 matching lines @@
     raise ValueError('could not find {0} in the manifest:\n{1}'.format(
         insert_before, ''.join(manifest_lines)))
   manifest_lines.insert(insert_index, inserted_string)
 
   modified_manifest_file = open(
       os.path.join(output_dir, manifest_name), 'w')
   modified_manifest_file.write(''.join(manifest_lines))
   modified_manifest_file.close()
 
 
+# Copy the relevant CRT DLLs to |build_dir|. We copy DLLs from all versions
+# of VS installed to make sure we have the correct CRT version, unused DLLs
+# should not conflict with the others anyways.
+def CopyVisualStudioRuntimeDLLs(build_dir):
+  is_debug = build_dir.endswith('Debug/')

[robertshield, 2012/05/22 02:39:59]

is the trailing slash guaranteed to be present? If not, can you use
os.path.normpath()? Also, os.path.basename() would be slightly better than
endswith() (though that requires normpath() to be called first).

[gab, 2012/05/22 15:44:46]

Yes, see [1] below.
I added [1] to make this "work", but I agree now that it's better to use os.path
methods. If you could change this, that'd be better I think.

Maybe replace [1] by os.path.normpath and then simply use os.path.basename here.

+  if not is_debug and not build_dir.endswith('Release/'):
+    print ("Warning: could not determine build configuration from "
+           "output directory, assuming Release build.")
+
+  crt_dlls = []
+  if is_debug:
+    crt_dlls = glob.glob(
+        "C:/Program Files (x86)/Microsoft Visual Studio */VC/redist/"
+        "Debug_NonRedist/x86/Microsoft.*.DebugCRT/*.dll")
+  else:
+    crt_dlls = glob.glob(
+        "C:/Program Files (x86)/Microsoft Visual Studio */VC/redist/x86/"
+        "Microsoft.*.CRT/*.dll")
+
+  # Also handle the case where someone is building using only winsdk and
+  # doesn't have Visual Studio installed.
+  if not crt_dlls:
+    # On a 64-bit system, 32-bit dlls are in SysWOW64 (don't ask).

[robertshield, 2012/05/22 02:39:59]

indeed :-)

[gab, 2012/05/22 15:44:46]

Aaaah! Thanks for clarifying :)!

+    if os.access("C:/Windows/SysWOW64", os.F_OK):
+      sys_dll_dir = "C:/Windows/SysWOW64"
+    else:
+      sys_dll_dir = "C:/Windows/System32"
+
+    if is_debug:
+      crt_dlls = glob.glob(sys_dll_dir + "/msvc*0d.dll")
+    else:
+      crt_dlls = glob.glob(sys_dll_dir + "/msvc*0.dll")
+
+  if not crt_dlls:
+    print ("Warning: could not find CRT DLLs to copy to build dir - target "
+           "may not run on a system that doesn't have those DLLs.")
+
+  for dll in crt_dlls:
+    shutil.copy(dll, build_dir)
+
+
 # Copies component build DLLs and generates required config files and manifests
 # in order for chrome.exe and setup.exe to be able to find those DLLs at
 # run-time.
 # This is meant for developer builds only and should never be used to package
 # an official build.
 def DoComponentBuildTasks(staging_dir, build_dir, current_version):
   # Get the required directories for the upcoming operations.
   chrome_dir = os.path.join(staging_dir, CHROME_DIR)
   version_dir = os.path.join(chrome_dir, current_version)
   installer_dir = os.path.join(version_dir, 'Installer')
   # |installer_dir| is technically only created post-install, but we need it
   # now to add setup.exe's config and manifest to the archive.
   if not os.path.exists(installer_dir):
     os.mkdir(installer_dir)
 
-  # Copy the relevant CRT DLLs to |build_dir|. We copy DLLs from all versions
-  # of VS installed to make sure we have the correct CRT version, unused DLLs
-  # should not conflict with the others anyways.
-  crt_dlls = []
-  if build_dir.endswith('Debug/'):
-    crt_dlls = glob.glob(
-        "C:/Program Files (x86)/Microsoft Visual Studio */VC/redist/"
-        "Debug_NonRedist/x86/Microsoft.*.DebugCRT/*.dll")
-  elif build_dir.endswith('Release/'):
-    crt_dlls = glob.glob(
-        "C:/Program Files (x86)/Microsoft Visual Studio */VC/redist/x86/"
-        "Microsoft.*.CRT/*.dll")
-  else:
-    print ("Warning: CRT DLLs not copied, could not determine build "
-           "configuration from output directory.")
-
-  for dll in crt_dlls:
-    shutil.copy(dll, build_dir)
+  CopyVisualStudioRuntimeDLLs(build_dir)

[gab, 2012/05/22 15:44:46]

optional: Add a comment as to why this needs to be done here. Something like:

// Copy the VS CRT DLLs to |build_dir|. This must be done before the
// general copy step below to ensure the CRT DLLs are added to the
// archive and marked as a dependency in the exe manifests generated
// below.

 
   # Copy all the DLLs in |build_dir| to the version directory. Simultaneously
   # build a list of their names to mark them as dependencies of chrome.exe and
   # setup.exe later.
   dlls = glob.glob(os.path.join(build_dir, '*.dll'))
   dll_names = []
   for dll in dlls:
     shutil.copy(dll, version_dir)
     dll_names.append(os.path.splitext(os.path.basename(dll))[0])
 
@@ skipping 149 matching lines @@
   parser.add_option('--enable_metro', default='0',
       help='Whether to include resource files from the "METRO" section of the '
            'input file.')
   parser.add_option('--component_build', default='0',
       help='Whether this archive is packaging a component build.')
 
   options, args = parser.parse_args()
   if not options.build_dir:
     parser.error('You must provide a build dir.')
   elif not options.build_dir.endswith('/'):
     options.build_dir += '/'

[gab, 2012/05/22 15:44:46]

[1]

 
   if not options.staging_dir:
     parser.error('You must provide a staging dir.')
 
   if not options.input_file:
     parser.error('You must provide an input file')
 
   if not options.output_dir:
     options.output_dir = options.build_dir
 
   if not options.resource_file_path:
     options.resource_file_path = os.path.join(options.build_dir,
                                               MINI_INSTALLER_INPUT_FILE)
 
   return options
 
 
 if '__main__' == __name__:
   print sys.argv
   sys.exit(main(_ParseOptions()))