Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 10406029: Implement positive test for Address Sanitizer in Chrome (Closed)

Created:
8 years, 7 months ago by glotov
Modified:
8 years, 7 months ago
Reviewers:
glotov1, Nirnimesh
CC:
chromium-reviews, Nirnimesh, kkania, anantha, robertshield, dyu1, dennis_jeffrey
Visibility:
Public.

Description

Implement positive test for Address Sanitizer in Chrome BUG=126774 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137846

Patch Set 1 #

Total comments: 4

Patch Set 2 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M chrome/browser/automation/testing_automation_provider.h View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/test/pyautolib/pyauto.py View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
glotov1
Hi! Please have a look.
8 years, 7 months ago (2012-05-17 14:48:36 UTC) #1
Nirnimesh
LGTM with nits. https://chromiumcodereview.appspot.com/10406029/diff/1/chrome/test/pyautolib/pyauto.py File chrome/test/pyautolib/pyauto.py (right): https://chromiumcodereview.appspot.com/10406029/diff/1/chrome/test/pyautolib/pyauto.py#newcode4030 chrome/test/pyautolib/pyauto.py:4030: """ Simulates a memory bug (reference ...
8 years, 7 months ago (2012-05-17 20:02:36 UTC) #2
glotov
http://codereview.chromium.org/10406029/diff/1/chrome/test/pyautolib/pyauto.py File chrome/test/pyautolib/pyauto.py (right): http://codereview.chromium.org/10406029/diff/1/chrome/test/pyautolib/pyauto.py#newcode4030 chrome/test/pyautolib/pyauto.py:4030: """ Simulates a memory bug (reference an array out ...
8 years, 7 months ago (2012-05-18 09:48:04 UTC) #3
Nirnimesh
8 years, 7 months ago (2012-05-18 11:11:54 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698