Implement Action Box button

chrome/browser/ui/views/location_bar/action_box_button_view.h

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.

[Aaron Boodman, 2012/05/17 20:42:05]

2012

[yefimt, 2012/05/17 22:42:52]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_ACTION_BOX_BUTTON_VIEW_H_
+#define CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_ACTION_BOX_BUTTON_VIEW_H_
+#pragma once
+
+#include "ui/views/controls/button/menu_button.h"
+#include "ui/views/controls/button/menu_button_listener.h"
+
+class CommandUpdater;
+
+namespace views {
+class KeyEvent;
+class MouseEvent;
+}
+
+class ActionBoxButtonView : public views::MenuButton,

[Aaron Boodman, 2012/05/17 20:42:05]

In the case of the wrench menu, the containing view plays the role of
MenuButtonListener. In your case, this would be LocationBarView.

I'm not sure if there's a reason why the containing view should be the listener,
but it seems more right somehow, and it would be good to be consistent if
nothing else.

+                            public views::MenuButtonListener {
+ public:
+  explicit ActionBoxButtonView(CommandUpdater* command_updater);
+  virtual ~ActionBoxButtonView();
+
+ private:
+  void SetImages();
+
+  virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;

[Aaron Boodman, 2012/05/17 20:42:05]

When implementing interfaces, it is customary to format like so:

// MenuButton
virtual void GetAccessibleState(...) OVERRIDE;

// MenuButtonListener
virtual void OnMenuButtonClicked(...) OVERRIDE;

[yefimt, 2012/05/17 22:42:52]

Done.

+
+  virtual void OnMenuButtonClicked(View* source, const gfx::Point& point);
+
+  // The CommandUpdater for the Browser object that owns the location bar.
+  CommandUpdater* command_updater_;
+
+  DISALLOW_IMPLICIT_CONSTRUCTORS(ActionBoxButtonView);
+};
+
+#endif  // CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_ACTION_BOX_BUTTON_VIEW_H_