Implement Action Box button

chrome/browser/ui/views/location_bar/action_box_button_view.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/views/location_bar/action_box_button_view.h"
+
+#include "base/utf_string_conversions.h"
+#include "chrome/app/chrome_command_ids.h"
+#include "chrome/browser/command_updater.h"
+#include "chrome/browser/ui/view_ids.h"
+#include "chrome/browser/ui/views/browser_dialogs.h"
+#include "grit/generated_resources.h"
+#include "grit/theme_resources.h"
+#include "grit/theme_resources_standard.h"
+#include "ui/base/accessibility/accessible_view_state.h"
+#include "ui/base/l10n/l10n_util.h"
+#include "ui/base/resource/resource_bundle.h"
+
+ActionBoxButtonView::ActionBoxButtonView(CommandUpdater* command_updater)
+    : views::MenuButton(NULL, string16(), this, false),
+      command_updater_(command_updater) {

[Aaron Boodman, 2012/05/17 20:42:05]

The command_updater_ is not used. Better to leave it out until it is.

[yefimt, 2012/05/17 22:42:52]

Done.

+  set_id(VIEW_ID_ACTION_BOX_BUTTON);
+  SetTooltipText(l10n_util::GetStringUTF16(IDS_TOOLTIP_ACTION_BOX_BUTTON));
+  SetImages();
+  set_accessibility_focusable(true);
+  set_border(NULL);
+}
+
+ActionBoxButtonView::~ActionBoxButtonView() {
+}
+
+void ActionBoxButtonView::SetImages() {

[Aaron Boodman, 2012/05/17 20:42:05]

In the case of AppMenuButtonView, the container does this, which seems sensible
to me. You might be able to get rid of this class if you move all the
configuration into the container.

+  const SkBitmap* icon = ui::ResourceBundle::GetSharedInstance().GetBitmapNamed(
+      IDR_ACTION_BOX_BUTTON);
+  if (icon)

[Aaron Boodman, 2012/05/17 20:42:05]

There's no case in which these icons won't be present, so remove the if
statement.

[yefimt, 2012/05/17 22:42:52]

Done.

+    SetIcon(*icon);
+  icon = ui::ResourceBundle::GetSharedInstance().GetBitmapNamed(
+      IDR_ACTION_BOX_BUTTON_H);
+  if (icon)
+    SetHoverIcon(*icon);
+  icon = ui::ResourceBundle::GetSharedInstance().GetBitmapNamed(
+      IDR_ACTION_BOX_BUTTON_P);
+  if (icon)
+    SetPushedIcon(*icon);
+}
+
+void ActionBoxButtonView::GetAccessibleState(ui::AccessibleViewState* state) {
+  MenuButton::GetAccessibleState(state);
+  state->name = l10n_util::GetStringUTF16(IDS_ACCNAME_ACTION_BOX_BUTTON);
+}
+
+void ActionBoxButtonView::OnMenuButtonClicked(View* source,
+                                              const gfx::Point& point) {
+}
+