Issue 1040002: Fix bug in the count operation where we statically know the input is a smi.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1040002: Fix bug in the count operation where we statically know the input is a smi. (Closed)

Created:
10 years, 9 months ago by fschneider

Modified:
9 years, 6 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix bug in the count operation where we statically know the input is a smi. Even if we know that the input to a count operation is a smi we still need to check if the result overflowed (and becomes a heap number). Also fix the smi loop analysis to take two border cases correctly into account. Committed: http://code.google.com/p/v8/source/detail?r=4147

Patch Set 1 #

Patch Set 2 : Rearranged comments #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -29 lines)			Patch
M	src/data-flow.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View	1	2 chunks	+34 lines, -29 lines	0 comments	Download
A	test/mjsunit/compiler/loopcount.js	View		1 chunk	+55 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages