Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 10399129: Added browser_process_main. (Closed)

Created:
8 years, 7 months ago by michaelbai
Modified:
8 years, 3 months ago
Reviewers:
Avi (use Gerrit), Yaron
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org, John Knottenbelt, jrg
Visibility:
Public.

Description

Added browser_process_main. As part of the content_shell bring up, some un-upstreamed features have been disabled in browser process main related c++ and Java file. The disabled features are guarded by !defined(ANDROID_UPSTREAM_BRINGUP). BUG= TEST=

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressed the comments #

Patch Set 3 : Fixed Java file style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+301 lines, -0 lines) Patch
A content/browser/android/browser_process_main.h View 1 chunk +13 lines, -0 lines 0 comments Download
A content/browser/android/browser_process_main.cc View 1 1 chunk +113 lines, -0 lines 0 comments Download
A content/common/android/process_main.h View 1 chunk +19 lines, -0 lines 0 comments Download
A content/common/android/process_main.cc View 1 chunk +32 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_common.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_jni.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
A content/public/android/java/org/chromium/content/browser/BrowserProcessMain.java View 1 2 1 chunk +118 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
michaelbai
8 years, 7 months ago (2012-05-22 19:28:17 UTC) #1
Yaron
lgtm Glad to see this getting started! I assume you've confirmed content shell still works ...
8 years, 7 months ago (2012-05-22 20:07:13 UTC) #2
Avi (use Gerrit)
https://chromiumcodereview.appspot.com/10399129/diff/1/content/browser/android/browser_process_main.cc File content/browser/android/browser_process_main.cc (right): https://chromiumcodereview.appspot.com/10399129/diff/1/content/browser/android/browser_process_main.cc#newcode11 content/browser/android/browser_process_main.cc:11: #include "base/command_line.h" alphabetize
8 years, 7 months ago (2012-05-22 20:09:23 UTC) #3
michaelbai
PTAL https://chromiumcodereview.appspot.com/10399129/diff/1/content/browser/android/browser_process_main.cc File content/browser/android/browser_process_main.cc (right): https://chromiumcodereview.appspot.com/10399129/diff/1/content/browser/android/browser_process_main.cc#newcode1 content/browser/android/browser_process_main.cc:1: // Copyright (c) 2011 The Chromium Authors. All ...
8 years, 7 months ago (2012-05-22 20:39:56 UTC) #4
Yaron
still lgtm
8 years, 7 months ago (2012-05-22 20:42:44 UTC) #5
Avi (use Gerrit)
lgtm
8 years, 7 months ago (2012-05-22 20:50:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/10399129/4004
8 years, 7 months ago (2012-05-22 20:56:31 UTC) #7
commit-bot: I haz the power
Presubmit check for 10399129-4004 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 7 months ago (2012-05-22 20:56:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/10399129/3004
8 years, 7 months ago (2012-05-22 21:47:21 UTC) #9
commit-bot: I haz the power
8 years, 7 months ago (2012-05-22 22:29:01 UTC) #10
Try job failure for 10399129-3004 (retry) on linux_rel for step "check_deps".
It's a second try, previously, step "check_deps" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Powered by Google App Engine
This is Rietveld 408576698