Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: base/base.gyp

Issue 10399126: Add APK targets for content_unittests and net_unittests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/apk_test.gypi » ('j') | build/apk_test.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/base.gyp
diff --git a/base/base.gyp b/base/base.gyp
index 99c826cbf48721234be00ef67e095371cf85b7d8..62e1f55c192848328fb494df7c6d11772d9c93c4 100644
--- a/base/base.gyp
+++ b/base/base.gyp
@@ -649,11 +649,6 @@
# in the gyp make generator. What is the correct way to extract
# this path from gyp and into 'raw' for input to antfiles?
# Hard-coding in the gypfile seems a poor choice.
- # TODO(jrg): there has to be a shorter way to do all this. Try
- # and convert this entire target cluster into ~5 lines that can be
- # trivially copied to other projects with only a deps change, such
- # as with a new gtest_target_type called
- # 'shared_library_apk_wrapper' that does a lot of this magically.
['OS=="android" and "<(gtest_target_type)"=="shared_library"', {
'targets': [
{
@@ -663,34 +658,11 @@
'base', # So that android/java/java.gyp:base_java is built
'base_unittests',
],
- 'actions': [
- {
- # Generate apk files (including source and antfile) from
- # a template, and builds them.
- 'action_name': 'generate_and_build',
- 'inputs': [
- '../testing/android/AndroidManifest.xml',
- '../testing/android/generate_native_test.py',
- '<(PRODUCT_DIR)/lib.target/libbase_unittests.so',
- '<(PRODUCT_DIR)/lib.java/chromium_base.jar'
- ],
- 'outputs': [
- '<(PRODUCT_DIR)/base_unittests_apk/base_unittests-debug.apk',
- ],
- 'action': [
- '../testing/android/generate_native_test.py',
- '--native_library',
- '<(PRODUCT_DIR)/lib.target/libbase_unittests.so',
- '--jar',
- '<(PRODUCT_DIR)/lib.java/chromium_base.jar',
- '--output',
- '<(PRODUCT_DIR)/base_unittests_apk',
- '--ant-args',
- '-DPRODUCT_DIR=<(PRODUCT_DIR)',
- '--ant-compile'
- ],
- },
- ]
+ 'variables': {
+ 'test_suite_name': 'base_unittests',
+ 'jar_name': 'chromium_base.jar',
+ },
+ 'includes': [ '../build/apk_test.gypi' ],
}],
}],
],
« no previous file with comments | « no previous file | build/apk_test.gypi » ('j') | build/apk_test.gypi » ('J')

Powered by Google App Engine
This is Rietveld 408576698