Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: remoting/host/vlog_net_log.cc

Issue 10399083: Make NetLog take in callbacks that return Values (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Fix merge error Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/host/vlog_net_log.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/vlog_net_log.cc
===================================================================
--- remoting/host/vlog_net_log.cc (revision 141317)
+++ remoting/host/vlog_net_log.cc (working copy)
@@ -19,15 +19,9 @@
VlogNetLog::~VlogNetLog() {
}
-void VlogNetLog::AddEntry(
- EventType type,
- const Source& source,
- EventPhase phase,
- const scoped_refptr<EventParameters>& params) {
+void VlogNetLog::OnAddEntry(const NetLog::Entry& entry) {
if (VLOG_IS_ON(4)) {
- scoped_ptr<Value> value(
- net::NetLog::EntryToDictionaryValue(
- type, base::TimeTicks::Now(), source, phase, params, false));
+ scoped_ptr<Value> value(entry.ToValue());
std::string json;
base::JSONWriter::Write(value.get(), &json);
VLOG(4) << json;
@@ -35,6 +29,7 @@
}
uint32 VlogNetLog::NextID() {
+ // TODO(mmenke): Make this threadsafe and start with 1 instead of 0.
return id_++;
}
« no previous file with comments | « remoting/host/vlog_net_log.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698