Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/url_request/url_request.cc

Issue 10399083: Make NetLog take in callbacks that return Values (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Update comments Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/http/http_response_headers.cc ('K') | « net/spdy/spdy_proxy_client_socket.cc ('k') | net/url_request/url_request_netlog_params.h » ('j') | remoting/host/vlog_net_log.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request.cc
===================================================================
--- net/url_request/url_request.cc (revision 140753)
+++ net/url_request/url_request.cc (working copy)
@@ -445,8 +445,8 @@
net_log_.BeginEvent(
NetLog::TYPE_URL_REQUEST_START_JOB,
- make_scoped_refptr(new URLRequestStartEventParameters(
- url(), method_, load_flags_, priority_)));
+ base::Bind(&NetLogURLRequestStartCallback,
+ url(), method_, load_flags_, priority_));
eroman 2012/06/06 21:27:11 perhaps url() and method_ should be passed as poin
mmenke 2012/06/07 19:20:46 Done. Go to all this effort not to have to copy t
job_ = job;
job_->SetExtraRequestHeaders(extra_request_headers_);
« net/http/http_response_headers.cc ('K') | « net/spdy/spdy_proxy_client_socket.cc ('k') | net/url_request/url_request_netlog_params.h » ('j') | remoting/host/vlog_net_log.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698