Make NetLog take in callbacks that return Values

chrome/browser/ui/webui/media/media_internals_proxy.cc

Index: chrome/browser/ui/webui/media/media_internals_proxy.cc
===================================================================
--- chrome/browser/ui/webui/media/media_internals_proxy.cc	(revision 140753)
+++ chrome/browser/ui/webui/media/media_internals_proxy.cc	(working copy)
@@ -80,14 +80,10 @@
       base::Bind(&MediaInternalsProxy::UpdateUIOnUIThread, this, update));
 }
 
-void MediaInternalsProxy::OnAddEntry(net::NetLog::EventType type,
-                                     const base::TimeTicks& time,
-                                     const net::NetLog::Source& source,
-                                     net::NetLog::EventPhase phase,
-                                     net::NetLog::EventParameters* params) {
+void MediaInternalsProxy::OnAddEntry(const net::NetLog::Entry& entry) {
   bool is_event_interesting = false;
   for (size_t i = 0; i < arraysize(kNetEventTypeFilter); i++) {
-    if (type == kNetEventTypeFilter[i]) {
+    if (entry.type() == kNetEventTypeFilter[i]) {
       is_event_interesting = true;
       break;
     }
@@ -99,8 +95,7 @@
   BrowserThread::PostTask(
       BrowserThread::UI, FROM_HERE,
       base::Bind(&MediaInternalsProxy::AddNetEventOnUIThread, this,
-          net::NetLog::EntryToDictionaryValue(type, time, source, phase,
-                                              params, false)));
+                 base::Owned(entry.ToValue())));

[eroman, 2012/06/06 21:27:11]

IMPORTANT: You sure about this? Looks like ownership is already being handled by
it internally, I think this will lead to a double-free

[mmenke, 2012/06/07 19:20:46]

You're right.  I was thinking of it as one of the new logging callbacks, for
some reason.

 }
 
 MediaInternalsProxy::~MediaInternalsProxy() {}