Make NetLog take in callbacks that return Values

remoting/host/vlog_net_log.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/vlog_net_log.h"
 
 #include "base/json/json_writer.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/time.h"
 #include "base/threading/thread_restrictions.h"
 #include "base/values.h"
 
 namespace remoting {
 
 VlogNetLog::VlogNetLog() : id_(0) {
 }
 
 VlogNetLog::~VlogNetLog() {
 }
 
-void VlogNetLog::AddEntry(
-    EventType type,
-    const Source& source,
-    EventPhase phase,
-    const scoped_refptr<EventParameters>& params) {
+void VlogNetLog::OnAddEntry(const NetLog::Entry& entry) {
   if (VLOG_IS_ON(4)) {
-    scoped_ptr<Value> value(
-        net::NetLog::EntryToDictionaryValue(
-            type, base::TimeTicks::Now(), source, phase, params, false));
+    scoped_ptr<Value> value(entry.ToValue());
     std::string json;
     base::JSONWriter::Write(value.get(), &json);
     VLOG(4) << json;
   }
 }
 
 uint32 VlogNetLog::NextID() {
   return id_++;

[mmenke, 2012/06/06 17:50:16]

This is not threadsafe, and the first ID should be 1, not 0.
I'll fix in a followup CL.  Not a lot of code, but this CL is already rather
big.

[eroman, 2012/06/06 21:27:11]

Perhaps add a TODO comment so it doesn't get forgotten.

[mmenke, 2012/06/07 19:20:46]

Added.

 }
 
 net::NetLog::LogLevel VlogNetLog::GetLogLevel() const {
   return LOG_ALL_BUT_BYTES;
 }
 
 void VlogNetLog::AddThreadSafeObserver(ThreadSafeObserver* observer,
                                       net::NetLog::LogLevel log_level) {
   NOTIMPLEMENTED();
 }
 
 void VlogNetLog::SetObserverLogLevel(ThreadSafeObserver* observer,
                                     net::NetLog::LogLevel log_level) {
   NOTIMPLEMENTED();
 }
 
 void VlogNetLog::RemoveThreadSafeObserver(ThreadSafeObserver* observer) {
   NOTIMPLEMENTED();
 }
 
 }  // namespace remoting