Moved instantiation of SpeechRecognitionManager inside browser_main_loop, instead of Singleton.

content/browser/speech/speech_recognition_manager_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_SPEECH_SPEECH_RECOGNITION_MANAGER_IMPL_H_
 #define CONTENT_BROWSER_SPEECH_SPEECH_RECOGNITION_MANAGER_IMPL_H_
 #pragma once
 
 #include <map>
 #include <string>
@@ skipping 33 matching lines @@
 //  - Handles the instantiation of SpeechRecognitionEngine objects when
 //    requested by SpeechRecognitionSessions.
 //  - Relays recognition results/status/error events of each session to the
 //    corresponding listener (demuxing on the base of their session_id).
 //  - Relays also recognition results/status/error events of every session to
 //    the catch-all snoop listener (optionally) provided by the delegate.
 class CONTENT_EXPORT SpeechRecognitionManagerImpl :
     public NON_EXPORTED_BASE(content::SpeechRecognitionManager),
     public content::SpeechRecognitionEventListener {
  public:
+  // Returns the current SpeechRecognitionManagerImpl. May return NULL if it
+  // hasn't been created yet.
   static SpeechRecognitionManagerImpl* GetInstance();
 
+  SpeechRecognitionManagerImpl();

[hans, 2012/05/15 15:32:31]

hmm, it feels weird having a public constructor when this is effectively going
to be a singleton?

[Primiano Tucci (use gerrit), 2012/05/15 16:04:03]

Hmm, the singleton was removed because it had a too large lifetime. Now it
behaves effectively as a singleton, but it lifecycle is managed by
BrowserMainLoop.
Made it protected and friend of BrowserMainLoop, perhaps it might look better.

+  virtual ~SpeechRecognitionManagerImpl();
+
   // SpeechRecognitionManager implementation.
   virtual int CreateSession(
       const content::SpeechRecognitionSessionConfig& config) OVERRIDE;
   virtual void StartSession(int session_id) OVERRIDE;
   virtual void AbortSession(int session_id) OVERRIDE;
   virtual void AbortAllSessionsForListener(
         content::SpeechRecognitionEventListener* listener) OVERRIDE;
   virtual void StopAudioCaptureForSession(int session_id) OVERRIDE;
   virtual const content::SpeechRecognitionSessionConfig& GetSessionConfig(
       int session_id) const OVERRIDE;
@@ skipping 16 matching lines @@
   virtual void OnSoundEnd(int session_id) OVERRIDE;
   virtual void OnAudioEnd(int session_id) OVERRIDE;
   virtual void OnRecognitionEnd(int session_id) OVERRIDE;
   virtual void OnRecognitionResult(
       int session_id, const content::SpeechRecognitionResult& result) OVERRIDE;
   virtual void OnRecognitionError(
       int session_id, const content::SpeechRecognitionError& error) OVERRIDE;
   virtual void OnAudioLevelsChange(int session_id, float volume,
                                    float noise_volume) OVERRIDE;
 
- protected:
-  // Private constructor to enforce singleton.
-  friend struct DefaultSingletonTraits<SpeechRecognitionManagerImpl>;
-  SpeechRecognitionManagerImpl();
-  virtual ~SpeechRecognitionManagerImpl();
-
  private:
   // Data types for the internal Finite State Machine (FSM).
   enum FSMState {
     SESSION_STATE_IDLE = 0,
     SESSION_STATE_CAPTURING_AUDIO,
     SESSION_STATE_WAITING_FOR_RESULT,
     SESSION_STATE_MAX_VALUE = SESSION_STATE_WAITING_FOR_RESULT
   };
 
   enum FSMEvent {
@@ skipping 43 matching lines @@
   const Session& GetSession(int session_id) const;
   content::SpeechRecognitionEventListener* GetListener(int session_id) const;
   content::SpeechRecognitionEventListener* GetDelegateListener() const;
   int GetNextSessionID();
 
   typedef std::map<int, Session> SessionsTable;
   SessionsTable sessions_;
   int session_id_capturing_audio_;
   int last_session_id_;
   bool is_dispatching_event_;
-  content::SpeechRecognitionManagerDelegate* delegate_;
+  scoped_ptr<content::SpeechRecognitionManagerDelegate> delegate_;
 };
 
 }  // namespace speech
 
 #endif  // CONTENT_BROWSER_SPEECH_SPEECH_RECOGNITION_MANAGER_IMPL_H_