Remove content::URLFetcherDelegate

chrome/common/net/gaia/oauth2_access_token_fetcher.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/net/gaia/oauth2_access_token_fetcher.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
 #include "base/json/json_reader.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
 #include "base/values.h"
 #include "chrome/common/net/gaia/gaia_urls.h"
 #include "chrome/common/net/gaia/google_service_auth_error.h"
 #include "net/base/escape.h"
 #include "net/base/load_flags.h"
 #include "net/http/http_status_code.h"
 #include "net/url_request/url_request_context_getter.h"
 #include "net/url_request/url_request_status.h"
 
 using content::URLFetcher;

[wtc, 2012/05/22 17:26:38]

This file uses a mixture of content::URLFetcher (elided as
URLFetcher) and net::URLFetcher.  Is that intentional?

Note: several other files have the same (potential) issue.

[akalin, 2012/05/22 21:07:05]

Not intentional, but it's harmless (since I'll remove content::URLFetcher in a
future CL).

Fixed it here (and others) anyway.

-using content::URLFetcherDelegate;
+using net::URLFetcherDelegate;

[wtc, 2012/05/22 17:26:38]

Nit: sort this?

Note: several other files have the same issue.

[akalin, 2012/05/22 21:07:05]

Done, sorted other files, too.

 using net::ResponseCookies;
 using net::URLRequestContextGetter;
 using net::URLRequestStatus;
 
 namespace {
 static const char kGetAccessTokenBodyFormat[] =
     "client_id=%s&"
     "client_secret=%s&"
     "grant_type=refresh_token&"
     "refresh_token=%s";
@@ skipping 158 matching lines @@
   CHECK(access_token);
   std::string data;
   source->GetResponseAsString(&data);
   scoped_ptr<base::Value> value(base::JSONReader::Read(data));
   if (!value.get() || value->GetType() != base::Value::TYPE_DICTIONARY)
     return false;
 
   DictionaryValue* dict = static_cast<DictionaryValue*>(value.get());
   return dict->GetString(kAccessTokenKey, access_token);
 }