Plumb texture target to VideoDecodeAccelerator::Client

ppapi/examples/video_decode/video_decode.cc

Index: ppapi/examples/video_decode/video_decode.cc
diff --git a/ppapi/examples/video_decode/video_decode.cc b/ppapi/examples/video_decode/video_decode.cc
index cced33afc3b2d0a3026f406658407c401268cd70..09dd249081d390d99c4c98834513f578261c4a02 100644
--- a/ppapi/examples/video_decode/video_decode.cc
+++ b/ppapi/examples/video_decode/video_decode.cc
@@ -60,9 +60,11 @@ class VideoDecodeDemoInstance : public pp::Instance,
   }
 
   // pp::VideoDecoderClient_Dev implementation.
-  virtual void ProvidePictureBuffers(PP_Resource decoder,
-                                     uint32_t req_num_of_bufs,
-                                     const PP_Size& dimensions);
+  virtual void ProvidePictureBuffers(
+      PP_Resource decoder,
+      uint32_t req_num_of_bufs,
+      const PP_Size& dimensions,
+      PP_VideoDecoder_TextureTarget_Dev texture_target);
   virtual void DismissPictureBuffer(PP_Resource decoder,
                                     int32_t picture_buffer_id);
   virtual void PictureReady(PP_Resource decoder, const PP_Picture_Dev& picture);
@@ -82,8 +84,10 @@ class VideoDecodeDemoInstance : public pp::Instance,
     void DecodeNextNALUs();
 
     // Per-decoder implementation of part of pp::VideoDecoderClient_Dev.
-    void ProvidePictureBuffers(uint32_t req_num_of_bufs,
-                               PP_Size dimensions);
+    void ProvidePictureBuffers(
+        uint32_t req_num_of_bufs,
+        PP_Size dimensions,
+        PP_VideoDecoder_TextureTarget_Dev texture_target);
     void DismissPictureBuffer(int32_t picture_buffer_id);
 
     const PP_PictureBuffer_Dev& GetPictureBufferById(int id);
@@ -323,14 +327,21 @@ void VideoDecodeDemoInstance::DecoderClient::DecodeNextNALU() {
 }
 
 void VideoDecodeDemoInstance::ProvidePictureBuffers(
-    PP_Resource decoder, uint32_t req_num_of_bufs, const PP_Size& dimensions) {
+    PP_Resource decoder,
+    uint32_t req_num_of_bufs,
+    const PP_Size& dimensions,
+    PP_VideoDecoder_TextureTarget_Dev texture_target) {
   DecoderClient* client = video_decoders_[decoder];
   assert(client);
-  client->ProvidePictureBuffers(req_num_of_bufs, dimensions);
+  client->ProvidePictureBuffers(req_num_of_bufs, dimensions, texture_target);
 }
 
 void VideoDecodeDemoInstance::DecoderClient::ProvidePictureBuffers(
-    uint32_t req_num_of_bufs, PP_Size dimensions) {
+    uint32_t req_num_of_bufs,
+    PP_Size dimensions,
+    PP_VideoDecoder_TextureTarget_Dev texture_target) {
+  // TODO(sail): Add support for ARB texture types.

[Ami GONE FROM CHROMIUM, 2012/05/23 23:42:33]

Can you do this as part of this CL?

[sail, 2012/05/29 18:58:09]

This part is implemented in this CL:
http://codereview.chromium.org/10411042/

I'd like to keep the change in a separate CL. If feel strongly that this
shouldn't be submitted like this then maybe I can wait for both to get an LGTM
and submit a single patch?

+  assert(texture_target == PP_VIDEODECODER_TEXTURE_TARGET_2D);
   std::vector<PP_PictureBuffer_Dev> buffers;
   for (uint32_t i = 0; i < req_num_of_bufs; ++i) {
     PP_PictureBuffer_Dev buffer;