Plumb texture target to VideoDecodeAccelerator::Client

media/video/video_decode_accelerator.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_VIDEO_VIDEO_DECODE_ACCELERATOR_H_
 #define MEDIA_VIDEO_VIDEO_DECODE_ACCELERATOR_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 34 matching lines @@
   // to the plugin, through the PPP_VideoDecode_Dev interface the plugin
   // implements.
   class MEDIA_EXPORT Client {
    public:
     virtual ~Client() {}
 
     // Callback to notify client that decoder has been initialized.
     virtual void NotifyInitializeDone() = 0;
 
     // Callback to tell client how many and what size of buffers to provide.
-    virtual void ProvidePictureBuffers(
-        uint32 requested_num_of_buffers, const gfx::Size& dimensions) = 0;
+    virtual void ProvidePictureBuffers(uint32 requested_num_of_buffers,
+                                       const gfx::Size& dimensions,
+                                       uint32 texture_target) = 0;
 
     // Callback to dismiss picture buffer that was assigned earlier.
     virtual void DismissPictureBuffer(int32 picture_buffer_id) = 0;
 
     // Callback to deliver decoded pictures ready to be displayed.
     virtual void PictureReady(const Picture& picture) = 0;
 
     // Callback to notify that decoded has decoded the end of the current
     // bitstream buffer.
     virtual void NotifyEndOfBitstreamBuffer(int32 bitstream_buffer_id) = 0;
@@ skipping 26 matching lines @@
 
   // Assigns a set of texture-backed picture buffers to the video decoder.
   //
   // Ownership of each picture buffer remains with the client, but the client
   // is not allowed to deallocate the buffer before the DismissPictureBuffer
   // callback has been initiated for a given buffer.
   //
   // Parameters:
   //  |buffers| contains the allocated picture buffers for the output.
   virtual void AssignPictureBuffers(
       const std::vector<PictureBuffer>& buffers) = 0;

[Ami GONE FROM CHROMIUM, 2012/05/29 23:32:35]

I wonder whether someday soon we'll regret not adding texture_target as a field
to PictureBuffer.

 
   // Sends picture buffers to be reused by the decoder. This needs to be called
   // for each buffer that has been processed so that decoder may know onto which
   // picture buffers it can write the output to.
   //
   // Parameters:
   //  |picture_buffer_id| id of the picture buffer that is to be reused.
   virtual void ReusePictureBuffer(int32 picture_buffer_id) = 0;
 
   // Flushes the decoder: all pending inputs will be decoded and pictures handed
@@ skipping 14 matching lines @@
   virtual void Destroy() = 0;
 
  protected:
   friend class base::RefCountedThreadSafe<VideoDecodeAccelerator>;
   virtual ~VideoDecodeAccelerator();
 };
 
 }  // namespace media
 
 #endif  // MEDIA_VIDEO_VIDEO_DECODE_ACCELERATOR_H_