Plumb texture target to VideoDecodeAccelerator::Client

media/video/video_decode_accelerator.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_VIDEO_VIDEO_DECODE_ACCELERATOR_H_
 #define MEDIA_VIDEO_VIDEO_DECODE_ACCELERATOR_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 21 matching lines @@
     // Invalid argument was passed to an API method.
     INVALID_ARGUMENT,
     // Encoded input is unreadable.
     UNREADABLE_INPUT,
     // A failure occurred at the browser layer or one of its dependencies.
     // Examples of such failures include GPU hardware failures, GPU driver
     // failures, GPU library failures, browser programming errors, and so on.
     PLATFORM_FAILURE,
   };
 
+  // Enumeration of texture targets that the decoder might request.
+  // Note: Keep these in sync with PP_VideoDecoder_TextureTarget_Dev.
+  enum TextureTarget {

[Ami GONE FROM CHROMIUM, 2012/05/23 23:42:33]

I don't think this (and its PP_VD_TT_D equivalent) are worth the extra
text/casting vs. just using a uint32 (like texture id).

[sail, 2012/05/29 18:58:09]

Done.

+    TEXTURE_TARGET_2D = 0,
+    TEXTURE_TARGET_ARB
+  };
+
   // Interface for collaborating with picture interface to provide memory for
   // output picture and blitting them.
   // This interface is extended by the various layers that relay messages back
   // to the plugin, through the PPP_VideoDecode_Dev interface the plugin
   // implements.
   class MEDIA_EXPORT Client {
    public:
     virtual ~Client() {}
 
     // Callback to notify client that decoder has been initialized.
     virtual void NotifyInitializeDone() = 0;
 
     // Callback to tell client how many and what size of buffers to provide.
-    virtual void ProvidePictureBuffers(
-        uint32 requested_num_of_buffers, const gfx::Size& dimensions) = 0;
+    virtual void ProvidePictureBuffers(uint32 requested_num_of_buffers,
+                                       const gfx::Size& dimensions,
+                                       TextureTarget texture_target) = 0;
 
     // Callback to dismiss picture buffer that was assigned earlier.
     virtual void DismissPictureBuffer(int32 picture_buffer_id) = 0;
 
     // Callback to deliver decoded pictures ready to be displayed.
     virtual void PictureReady(const Picture& picture) = 0;
 
     // Callback to notify that decoded has decoded the end of the current
     // bitstream buffer.
     virtual void NotifyEndOfBitstreamBuffer(int32 bitstream_buffer_id) = 0;
@@ skipping 67 matching lines @@
   virtual void Destroy() = 0;
 
  protected:
   friend class base::RefCountedThreadSafe<VideoDecodeAccelerator>;
   virtual ~VideoDecodeAccelerator();
 };
 
 }  // namespace media
 
 #endif  // MEDIA_VIDEO_VIDEO_DECODE_ACCELERATOR_H_