Plumb texture target to VideoDecodeAccelerator::Client

media/filters/gpu_video_decoder.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/filters/gpu_video_decoder.h"
 
 #include "base/bind.h"
 #include "base/callback_helpers.h"
 #include "base/message_loop.h"
 #include "base/stl_util.h"
@@ skipping 298 matching lines @@
         &GpuVideoDecoder::PrepareForShutdownHack, this));
     return;
   }
   shutting_down_ = true;
 }
 
 void GpuVideoDecoder::NotifyInitializeDone() {
   NOTREACHED() << "GpuVideoDecodeAcceleratorHost::Initialize is synchronous!";
 }
 
-void GpuVideoDecoder::ProvidePictureBuffers(uint32 count,
-                                            const gfx::Size& size) {
+void GpuVideoDecoder::ProvidePictureBuffers(
+    uint32 count,
+    const gfx::Size& size,
+    media::VideoDecodeAccelerator::TextureTarget texture_target) {
   if (!gvd_loop_proxy_->BelongsToCurrentThread()) {
     gvd_loop_proxy_->PostTask(FROM_HERE, base::Bind(
-        &GpuVideoDecoder::ProvidePictureBuffers, this, count, size));
+        &GpuVideoDecoder::ProvidePictureBuffers, this, count, size,
+        texture_target));
     return;
   }
 
+  // TODO(sail) : Add support for ARB texture targets.

[Ami GONE FROM CHROMIUM, 2012/05/23 23:42:33]

I think it's important to do these TODOs before the CL lands as a sanity check. 
For example, see 5 lines down.

[sail, 2012/05/29 18:58:09]

Done.

+  CHECK_EQ(media::VideoDecodeAccelerator::TEXTURE_TARGET_2D, texture_target);
+
   std::vector<uint32> texture_ids;
   if (!factories_->CreateTextures(
       count, size, &texture_ids, &decoder_texture_target_)) {

[Ami GONE FROM CHROMIUM, 2012/05/23 23:42:33]

Here CreateTextures() expects to be able to proscribe which target the texture
was created against.
In fact, it doesn't need freedom, but the resulting textures need to be tagged
w/ their targets.

So I think you should replace the TODO at l330 above with passing the
texture_target arg to PPB on to Factories::CreateTextures() and use the
passed-in texture value there (and change CreateTextures() to accept the target
as an input instead of output param).

[sail, 2012/05/29 18:58:09]

Done.

     NotifyError(VideoDecodeAccelerator::PLATFORM_FAILURE);
     return;
   }
 
   if (!vda_)
     return;
 
   std::vector<PictureBuffer> picture_buffers;
   for (size_t i = 0; i < texture_ids.size(); ++i) {
     picture_buffers.push_back(PictureBuffer(
@@ skipping 194 matching lines @@
 
   error_occured_ = true;
 
   if (!pending_read_cb_.is_null()) {
     base::ResetAndReturn(&pending_read_cb_).Run(kDecodeError, NULL);
     return;
   }
 }
 
 }  // namespace media