Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: content/browser/download/download_stats.cc

Issue 10392111: Use ByteStream in downloads system to decouple source and sink. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sync'd to LKGR. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_stats.cc
diff --git a/content/browser/download/download_stats.cc b/content/browser/download/download_stats.cc
index 40ed9123d8ebf4fcf09a9da2b998fbd8346158bc..63329937c53b9b6d88cb22fa8f32a0bd59289ab1 100644
--- a/content/browser/download/download_stats.cc
+++ b/content/browser/download/download_stats.cc
@@ -255,8 +255,7 @@ void RecordDownloadMimeType(const std::string& mime_type_string) {
void RecordFileThreadReceiveBuffers(size_t num_buffers) {
UMA_HISTOGRAM_CUSTOM_COUNTS(
"Download.FileThreadReceiveBuffers", num_buffers, 1,
- DownloadResourceHandler::kLoadsToWrite,
- DownloadResourceHandler::kLoadsToWrite);
+ 100, 100);
}
void RecordBandwidth(double actual_bandwidth, double potential_bandwidth) {
@@ -303,6 +302,45 @@ void RecordOpensOutstanding(int size) {
64/*num_buckets*/);
}
+void RecordContiguousWriteTime(base::TimeDelta time_blocked) {
+ UMA_HISTOGRAM_TIMES("Download.FileThreadBlockedTime", time_blocked);
+}
+
+void RecordNetworkBandwidth(size_t length,
+ base::TimeDelta elapsed_time,
+ base::TimeDelta paused_time) {
+ size_t non_pause_time_ms = (elapsed_time - paused_time).InMilliseconds();
+ if (0u == non_pause_time_ms)
+ non_pause_time_ms = 1;
+
+ // Note that this will be somewhat higher than sustainable network
+ // bandwidth because of buffering in the kernel during pauses.
+ // Using Bytes/s rather than bits/s so that this value is easily
+ // comparable with BandwidthOverall and BandwidthDisk.
+ UMA_HISTOGRAM_CUSTOM_COUNTS(
+ "Download.BandwidthNetworkBytesPerSecond",
+ (1000 * length / non_pause_time_ms),
+ 1, 100000000, 50);
+}
+
+void RecordFileBandwidth(size_t length,
+ base::TimeDelta disk_write_time,
+ base::TimeDelta elapsed_time) {
+ size_t elapsed_time_ms = elapsed_time.InMilliseconds();
+ if (0u == elapsed_time_ms)
+ elapsed_time_ms = 1;
+ size_t disk_write_time_ms = disk_write_time.InMilliseconds();
+ if (0u == disk_write_time_ms)
+ disk_write_time_ms = 1;
+
+ UMA_HISTOGRAM_CUSTOM_COUNTS(
+ "Download.BandwidthOverallBytesPerSecond",
+ (1000 * length / elapsed_time_ms), 1, 50000000, 50);
+ UMA_HISTOGRAM_CUSTOM_COUNTS(
+ "Download.BandwidthDiskBytesPerSecond",
+ (1000 * length / disk_write_time_ms), 1, 50000000, 50);
+}
+
void RecordSavePackageEvent(SavePackageEvent event) {
UMA_HISTOGRAM_ENUMERATION("Download.SavePackage",
event,
« no previous file with comments | « content/browser/download/download_stats.h ('k') | content/browser/renderer_host/resource_dispatcher_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698