content/test/net/url_request_slow_download_job.cc - Issue 10392111: Use ByteStream in downloads system to decouple source and sink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/net/url_request_slow_download_job.cc

Issue 10392111: Use ByteStream in downloads system to decouple source and sink. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Results of self code review. Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/test/net/url_request_slow_download_job.cc

diff --git a/content/test/net/url_request_slow_download_job.cc b/content/test/net/url_request_slow_download_job.cc

index 3ba1be72a950bc33a9a758543ac0a1448593d1a5..ba32d2364dc7d333b6e2e5cf1b10204f1e04f4cc 100644

--- a/content/test/net/url_request_slow_download_job.cc

+++ b/content/test/net/url_request_slow_download_job.cc

@@ -185,6 +185,8 @@ void URLRequestSlowDownloadJob::CheckDoneStatus() {

ReadStatus status = FillBufferHelper(buffer_, buffer_size_, &bytes_written);

DCHECK_EQ(BUFFER_FILLED, status);

SetStatus(net::URLRequestStatus());

+ // Release reference

+ buffer_ = NULL;

Randy Smith (Not in Mondays) 2012/05/19 15:29:57 This has already landed, and will disappear from t

Randy Smith (Not in Mondays) 2012/05/23 03:33:15 Done.

NotifyReadComplete(bytes_written);

} else {

MessageLoop::current()->PostDelayedTask(