Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(978)

Unified Diff: net/url_request/url_request_test_job.cc

Issue 10392111: Use ByteStream in downloads system to decouple source and sink. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix old merge error. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_test_job.cc
diff --git a/net/url_request/url_request_test_job.cc b/net/url_request/url_request_test_job.cc
index 4a0ba6e21291ca62a345ff57ca84526eefd59129..d501d0b7d2411acfda4fc11704ad033b87e95504 100644
--- a/net/url_request/url_request_test_job.cc
+++ b/net/url_request/url_request_test_job.cc
@@ -247,7 +247,12 @@ void URLRequestTestJob::ProcessNextOperation() {
if (!ReadRawData(async_buf_, async_buf_size_, &bytes_read))
NOTREACHED() << "This should not return false in DATA_AVAILABLE.";
SetStatus(URLRequestStatus()); // clear the io pending flag
+ if (FinalRoundIOPending()) {
+ // Make any nested read calls return IO_PENDING.
rvargas (doing something else) 2012/05/29 18:13:36 This actually requires nested read calls for it to
Randy Smith (Not in Mondays) 2012/05/30 00:22:32 I renamed the upcall and changed it's semantics to
+ stage_ = WAITING;
+ }
NotifyReadComplete(bytes_read);
+ stage_ = DATA_AVAILABLE;
}
break;
case DATA_AVAILABLE:
@@ -265,6 +270,10 @@ void URLRequestTestJob::ProcessNextOperation() {
}
}
+bool URLRequestTestJob::FinalRoundIOPending() {
+ return false;
+}
+
void URLRequestTestJob::AdvanceJob() {
if (auto_advance_) {
MessageLoop::current()->PostTask(

Powered by Google App Engine
This is Rietveld 408576698