Use ByteStream in downloads system to decouple source and sink.

content/browser/download/download_item_impl_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/message_loop.h"
 #include "base/stl_util.h"
 #include "base/threading/thread.h"
+#include "content/browser/download/byte_stream.h"
 #include "content/browser/download/download_create_info.h"
 #include "content/browser/download/download_file_manager.h"
 #include "content/browser/download/download_item_impl.h"
 #include "content/browser/download/download_request_handle.h"
 #include "content/public/browser/download_id.h"
 #include "content/public/browser/download_interrupt_reasons.h"
 #include "content/public/test/mock_download_item.h"
 #include "content/public/test/test_browser_thread.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 33 matching lines @@
   MOCK_CONST_METHOD0(GetDownloadManager, DownloadManager*());
   MOCK_CONST_METHOD0(PauseRequest, void());
   MOCK_CONST_METHOD0(ResumeRequest, void());
   MOCK_CONST_METHOD0(CancelRequest, void());
   MOCK_CONST_METHOD0(DebugString, std::string());
 };
 
 class MockDownloadFileFactory
     : public DownloadFileManager::DownloadFileFactory {
  public:
-  MOCK_METHOD5(CreateFile,
+  content::DownloadFile* CreateFile(
+      DownloadCreateInfo* info,
+      scoped_ptr<content::ByteStreamReader> stream_reader,
+      const DownloadRequestHandle& request_handle,
+      DownloadManager* mgr,
+      bool calculate_hash,
+      const net::BoundNetLog& bound_net_log) {
+    return MockCreateFile(
+        info, stream_reader.get(), request_handle, mgr, calculate_hash,
+        bound_net_log);
+  }
+
+  MOCK_METHOD6(MockCreateFile,
                content::DownloadFile*(DownloadCreateInfo*,
+                                      content::ByteStreamReader*,
                                       const DownloadRequestHandle&,
                                       DownloadManager*,
                                       bool,
                                       const net::BoundNetLog&));
 };
 
 class MockDownloadFileManager : public DownloadFileManager {
  public:
   MockDownloadFileManager();
   MOCK_METHOD0(Shutdown, void());
-  MOCK_METHOD2(StartDownload,
-               void(DownloadCreateInfo*, const DownloadRequestHandle&));
-  MOCK_METHOD2(UpdateDownload, void(DownloadId, content::DownloadBuffer*));
-  MOCK_METHOD3(OnResponseCompleted,
-               void(DownloadId, content::DownloadInterruptReason,
-                    const std::string&));
+  MOCK_METHOD3(MockStartDownload,
+               void(DownloadCreateInfo*, content::ByteStreamReader*,
+                    const DownloadRequestHandle&));
+  virtual void StartDownload(scoped_ptr<DownloadCreateInfo> info,
+                            scoped_ptr<content::ByteStreamReader> stream,
+                            const DownloadRequestHandle& request_handle) {
+    MockStartDownload(info.release(), stream.release(), request_handle);
+  }
+
   MOCK_METHOD1(CancelDownload, void(DownloadId));
   MOCK_METHOD1(CompleteDownload, void(DownloadId));
   MOCK_METHOD1(OnDownloadManagerShutdown, void(DownloadManager*));
   MOCK_METHOD4(RenameInProgressDownloadFile,
                void(DownloadId, const FilePath&, bool,
                     const RenameCompletionCallback&));
   MOCK_METHOD4(RenameCompletingDownloadFile,
                void(DownloadId, const FilePath&, bool,
                     const RenameCompletionCallback&));
   MOCK_CONST_METHOD0(NumberOfActiveDownloads, int());
@@ skipping 440 matching lines @@
                                  final_path))));
   item->OnDownloadCompleting(file_manager.get());
   RunAllPendingInMessageLoops();
   ::testing::Mock::VerifyAndClearExpectations(file_manager.get());
   ::testing::Mock::VerifyAndClearExpectations(mock_delegate());
 }
 
 TEST(MockDownloadItem, Compiles) {
   MockDownloadItem mock_item;
 }