chrome/renderer/resources/extensions/declarative_webrequest_custom_bindings.js - Issue 10392008: Move declarative API into events API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/declarative_webrequest_custom_bindings.js

Issue 10392008: Move declarative API into events API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed comments Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/resources/extensions/declarative_custom_bindings.js ('k') | chrome/renderer/resources/extensions/event.js » ('j') | chrome/renderer/resources/extensions/event.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/declarative_webrequest_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/declarative_webrequest_custom_bindings.js b/chrome/renderer/resources/extensions/declarative_webrequest_custom_bindings.js

index 9ae24cc69f7238729a7c8f37398411cd7f9d76a1..718590c14b9d9458a7abe73b6c84bbf6f7cdbb74 100644

--- a/chrome/renderer/resources/extensions/declarative_webrequest_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/declarative_webrequest_custom_bindings.js

@@ -5,14 +5,13 @@

// Custom bindings for the declarativeWebRequest API.

var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();

+var lookup = require('utils').lookup;

chromeHidden.registerCustomHook('declarativeWebRequest', function(api) {

// Returns the schema definition of type |typeId| defined in |namespace|.

function getSchema(namespace, typeId) {

- var filterNamespace = function(val) {return val.namespace === namespace;};

- var apiSchema = api.apiDefinitions.filter(filterNamespace)[0];

- var filterTypeId = function (val) {return val.id === typeId;};

- var resultSchema = apiSchema.types.filter(filterTypeId)[0];

+ var apiSchema = lookup(api.apiDefinitions, 'namespace', namespace);

+ var resultSchema = lookup(apiSchema.types, 'id', typeId);

return resultSchema;

}