Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10392004: Add a runtime switch to control whether NaCl uses the IPC or SRPC Proxy. (Closed)

Created:
8 years, 7 months ago by bbudge
Modified:
8 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Add a runtime switch to control whether NaCl uses the IPC or SRPC Proxy. BUG=116317 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136432

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/nacl_cmd_line.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bbudge
8 years, 7 months ago (2012-05-09 12:57:48 UTC) #1
bbudge
+ changes to pass flag to appropriate processes
8 years, 7 months ago (2012-05-09 16:42:15 UTC) #2
brettw
lgtm http://codereview.chromium.org/10392004/diff/5001/chrome/common/chrome_switches.cc File chrome/common/chrome_switches.cc (right): http://codereview.chromium.org/10392004/diff/5001/chrome/common/chrome_switches.cc#newcode555 chrome/common/chrome_switches.cc:555: const char kEnableNaClIPCProxy[] = "enable-nacl-ipc-proxy"; Can you align ...
8 years, 7 months ago (2012-05-10 21:20:48 UTC) #3
bbudge
http://codereview.chromium.org/10392004/diff/5001/chrome/common/chrome_switches.cc File chrome/common/chrome_switches.cc (right): http://codereview.chromium.org/10392004/diff/5001/chrome/common/chrome_switches.cc#newcode555 chrome/common/chrome_switches.cc:555: const char kEnableNaClIPCProxy[] = "enable-nacl-ipc-proxy"; On 2012/05/10 21:20:48, brettw ...
8 years, 7 months ago (2012-05-10 21:23:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/10392004/9001
8 years, 7 months ago (2012-05-10 21:24:04 UTC) #5
commit-bot: I haz the power
8 years, 7 months ago (2012-05-10 23:07:07 UTC) #6 
Change committed as 136432

Powered by Google App Engine
This is Rietveld 408576698