Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/allocator/allocator_extension_thunks.cc

Issue 10391178: 1. Enable large object pointer offset check in release build. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/allocator/allocator.gyp ('K') | « base/allocator/allocator.gyp ('k') | base/allocator/allocator_shim.h » ('j') | base/allocator/tcmalloc_free_check_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/allocator/allocator_extension_thunks.cc
===================================================================
--- base/allocator/allocator_extension_thunks.cc (revision 137587)
+++ base/allocator/allocator_extension_thunks.cc (working copy)
@@ -11,10 +11,11 @@
namespace thunks {
// This slightly odd translation unit exists because of the peculularity of how
-// allocator_unittests works on windows. That target has to perform
-// tcmalloc-specific initialization on windows, but it cannot depend on base
-// otherwise. This target sits in the middle - both libbase and
-// allocator_unittests can depend on it.
+// allocator_unittests and tcmalloc tests work on windows. That target has
+// to perform tcmalloc-specific initialization on windows, but it cannot depend
+// on base otherwise.
+// This target sits in the middle - libbase, allocator_unittests and tcmalloc
rvargas (doing something else) 2012/05/19 01:08:04 nit: libbase -> base
kaiwang 2012/05/21 18:11:42 Done.
+// tests can depend on it.
// This file can't depend on anything else in base, including logging.
static GetStatsFunction* g_get_stats_function = NULL;
« base/allocator/allocator.gyp ('K') | « base/allocator/allocator.gyp ('k') | base/allocator/allocator_shim.h » ('j') | base/allocator/tcmalloc_free_check_test.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698