Add RequestUpdate to NetworkSmsHandler

chromeos/network/network_sms_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/network/network_sms_handler.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
@@ skipping 17 matching lines @@
 const char NetworkSmsHandler::kNumberKey[] = "number";
 const char NetworkSmsHandler::kTextKey[] = "text";
 const char NetworkSmsHandler::kTimestampKey[] = "timestamp";
 
 class NetworkSmsHandler::NetworkSmsDeviceHandler {
  public:
   NetworkSmsDeviceHandler(NetworkSmsHandler* host,
                           std::string dbus_connection,
                           dbus::ObjectPath object_path);
 
+  void RequestUpdate();
+
  private:
   void ListCallback(const base::ListValue& message_list);
   void SmsReceivedCallback(uint32 index, bool complete);
   void GetCallback(uint32 index, const base::DictionaryValue& dictionary);
   void DeleteMessages();
   void NotifyMessageReceived(const base::DictionaryValue& dictionary);
 
   NetworkSmsHandler* host_;
   std::string dbus_connection_;
   dbus::ObjectPath object_path_;
@@ skipping 19 matching lines @@
       base::Bind(&NetworkSmsDeviceHandler::SmsReceivedCallback,
                  weak_ptr_factory_.GetWeakPtr()));
 
   // List the existing messages.
   DBusThreadManager::Get()->GetGsmSMSClient()->List(
       dbus_connection_, object_path_,
       base::Bind(&NetworkSmsDeviceHandler::ListCallback,
                  weak_ptr_factory_.GetWeakPtr()));
 }
 
+void NetworkSmsHandler::NetworkSmsDeviceHandler::RequestUpdate() {
+  DBusThreadManager::Get()->GetGsmSMSClient()->RequestUpdate(
+      dbus_connection_, object_path_);
+}
+
 void NetworkSmsHandler::NetworkSmsDeviceHandler::ListCallback(
     const base::ListValue& message_list) {
   // This receives all messages, so clear any pending deletes.
   delete_queue_.clear();
   for (base::ListValue::const_iterator iter = message_list.begin();
        iter != message_list.end(); ++iter) {
     base::DictionaryValue* message = NULL;
     if (!(*iter)->GetAsDictionary(&message))
       continue;
     NotifyMessageReceived(*message);
@@ skipping 57 matching lines @@
 NetworkSmsHandler::~NetworkSmsHandler() {
 }
 
 void NetworkSmsHandler::Init() {
   // Request network manager properties so that we can get the list of devices.
   DBusThreadManager::Get()->GetFlimflamManagerClient()->GetProperties(
       base::Bind(&NetworkSmsHandler::ManagerPropertiesCallback,
                  weak_ptr_factory_.GetWeakPtr()));
 }
 
+void NetworkSmsHandler::RequestUpdate() {
+  for (ScopedVector<NetworkSmsDeviceHandler>::iterator iter =
+           device_handlers_.begin(); iter != device_handlers_.end(); ++iter)
+    (*iter)->RequestUpdate();

[satorux1, 2012/05/16 20:59:10]

nit: add {} ? If I understand right, we omit {} only if the conditional and the
body are both one line.

[stevenjb, 2012/05/16 21:12:13]

Done.

+}
+
 void NetworkSmsHandler::AddObserver(Observer* observer) {
   observers_.AddObserver(observer);
 }
 
 void NetworkSmsHandler::RemoveObserver(Observer* observer) {
   observers_.RemoveObserver(observer);
 }
 
 void NetworkSmsHandler::NotifyMessageReceived(
     const base::DictionaryValue& message) {
@@ skipping 59 matching lines @@
     LOG(ERROR) << "Device has no DBusObject Property: " << device_path;
     return;
   }
   dbus::ObjectPath object_path(object_path_string);
   device_handlers_.push_back(
       new NetworkSmsDeviceHandler(this, dbus_connection, object_path));
 }
 
 
 }  // namespace chromeos