chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc - Issue 10391158: Moves methods for finding browsers to browser_finder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc

Issue 10391158: Moves methods for finding browsers to browser_finder. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Include fixs Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser_finder.h ('K') | « chrome/browser/ui/views/ash/panel_view_aura.cc ('k') | chrome/browser/ui/views/extensions/extension_install_dialog_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc b/chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc

index 89851e64765ce315c1c16e95d59e4dd6097cb48f..942be774f448e0f961e8689cd4f59c36413be347 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc

@@ -13,7 +13,7 @@

#include "chrome/browser/prefs/pref_service.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser.h"

-#include "chrome/browser/ui/browser_list.h"

+#include "chrome/browser/ui/browser_finder.h"

#include "chrome/common/pref_names.h"

#include "content/public/browser/page_navigator.h"

#include "content/public/browser/user_metrics.h"

@@ -190,7 +190,7 @@ void BookmarkContextMenuControllerViews::ExecuteCommand(int id) {

case IDC_BOOKMARK_MANAGER: {

content::RecordAction(UserMetricsAction("ShowBookmarkManager"));

- Browser* browser = BrowserList::GetLastActiveWithProfile(profile_);

+ Browser* browser = browser::FindLastActiveWithProfile(profile_);

if (!browser) NOTREACHED();

if (selection_.size() != 1)