chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm - Issue 10391158: Moves methods for finding browsers to browser_finder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm

Issue 10391158: Moves methods for finding browsers to browser_finder. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Include fixs Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser_finder.h ('K') | « chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm ('k') | chrome/browser/ui/cocoa/extensions/extension_installed_bubble_bridge.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm

index 2495fe9b632e033a2cd8c34749671d420b9805ef..504edb9350e238b15e819074fb1bd07a49963f93 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm

@@ -14,7 +14,7 @@

#include "chrome/browser/extensions/bundle_installer.h"

#include "chrome/browser/extensions/extension_install_dialog.h"

#include "chrome/browser/ui/browser.h"

-#include "chrome/browser/ui/browser_list.h"

+#include "chrome/browser/ui/browser_finder.h"

#include "chrome/browser/ui/browser_window.h"

#include "chrome/common/extensions/extension.h"

#include "grit/generated_resources.h"

@@ -135,7 +135,7 @@ void AppendRatingStarsShim(const SkBitmap* skiaImage, void* data) {

- (IBAction)storeLinkClicked:(id)sender {

GURL store_url(extension_urls::GetWebstoreItemDetailURLPrefix() +

prompt_->extension()->id());

- BrowserList::GetLastActiveWithProfile(profile_)->OpenURL(OpenURLParams(

+ browser::FindLastActiveWithProfile(profile_)->OpenURL(OpenURLParams(

store_url, Referrer(), NEW_FOREGROUND_TAB, content::PAGE_TRANSITION_LINK,

false));

@@ -321,7 +321,7 @@ void ShowExtensionInstallDialogImpl(

Profile* profile,

ExtensionInstallUI::Delegate* delegate,

const ExtensionInstallUI::Prompt& prompt) {

- Browser* browser = BrowserList::GetLastActiveWithProfile(profile);

+ Browser* browser = browser::FindLastActiveWithProfile(profile);

if (!browser) {

delegate->InstallUIAbort(false);

return;