chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm - Issue 10391158: Moves methods for finding browsers to browser_finder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

Issue 10391158: Moves methods for finding browsers to browser_finder. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Include fixs Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser_finder.h ('K') | « chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript.mm ('k') | chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

index 1053e8c0f34765a6c970e865231309614c822eea..7a98a248f1d53f6603c67bf03ccfa5b4ee7072e1 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

@@ -11,6 +11,7 @@

#include "chrome/browser/bookmarks/bookmark_model.h"

#include "chrome/browser/bookmarks/bookmark_utils.h"

#include "chrome/browser/ui/browser.h"

+#include "chrome/browser/ui/browser_finder.h"

#import "chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.h"

#include "chrome/browser/ui/cocoa/event_utils.h"

#include "content/public/browser/user_metrics.h"

@@ -92,7 +93,7 @@ const NSUInteger kMaximumMenuPixelsWide = 300;

// Open the URL of the given BookmarkNode in the current tab.

- (void)openURLForNode:(const BookmarkNode*)node {

- Browser* browser = Browser::GetTabbedBrowser(bridge_->GetProfile(), true);

+ Browser* browser = browser::FindTabbedBrowser(bridge_->GetProfile(), true);

if (!browser)

browser = Browser::Create(bridge_->GetProfile());

WindowOpenDisposition disposition =

@@ -111,7 +112,7 @@ const NSUInteger kMaximumMenuPixelsWide = 300;

const BookmarkNode* node = [self nodeForIdentifier:identifier];

DCHECK(node);

- Browser* browser = Browser::GetTabbedBrowser(bridge_->GetProfile(), true);

+ Browser* browser = browser::FindTabbedBrowser(bridge_->GetProfile(), true);

if (!browser)

browser = Browser::Create(bridge_->GetProfile());

DCHECK(browser);