Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1890)

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 10391134: Fix memory leak in PrerenderDispatcher. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: make chrome_content_renderer_client own the prerendering_support implementation Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/chrome_content_renderer_client.cc
diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc
index ddd22acb5d08bd5975dcefadcd121612cacf29cf..6b7aa58df0852ff82ae1e36789cbf5cbd96b5857 100644
--- a/chrome/renderer/chrome_content_renderer_client.cc
+++ b/chrome/renderer/chrome_content_renderer_client.cc
@@ -54,6 +54,7 @@
#include "chrome/renderer/prerender/prerender_helper.h"
#include "chrome/renderer/prerender/prerender_webmediaplayer.h"
#include "chrome/renderer/prerender/prerenderer_client.h"
+#include "chrome/renderer/prerender/prerendering_support.h"
#include "chrome/renderer/print_web_view_helper.h"
#include "chrome/renderer/renderer_histogram_snapshots.h"
#include "chrome/renderer/safe_browsing/malware_dom_details.h"
@@ -72,6 +73,7 @@
#include "grit/renderer_resources.h"
#include "ipc/ipc_sync_channel.h"
#include "net/base/net_errors.h"
+#include "third_party/WebKit/Source/Platform/chromium/public/WebPrerenderingSupport.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/WebCache.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/WebDataSource.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/WebDocument.h"
@@ -147,6 +149,8 @@ ChromeContentRendererClient::ChromeContentRendererClient() {
}
ChromeContentRendererClient::~ChromeContentRendererClient() {
+ if (prerendering_support_.get())
+ WebKit::WebPrerenderingSupport::shutdown();
}
void ChromeContentRendererClient::RenderThreadStarted() {
@@ -173,6 +177,9 @@ void ChromeContentRendererClient::RenderThreadStarted() {
thread->AddObserver(visited_link_slave_.get());
thread->AddObserver(prerender_dispatcher_.get());
+ prerendering_support_.reset(new prerender::PrerenderingSupport());
dominich 2012/05/18 14:48:09 Could you move these two lines up to 166? It would
+ WebKit::WebPrerenderingSupport::initialize(prerendering_support_.get());
+
thread->RegisterExtension(extensions_v8::ExternalExtension::Get());
thread->RegisterExtension(extensions_v8::LoadTimesExtension::Get());
thread->RegisterExtension(extensions_v8::SearchBoxExtension::Get());

Powered by Google App Engine
This is Rietveld 408576698