Test for Pepper IME events.

webkit/plugins/ppapi/resource_creation_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/plugins/ppapi/resource_creation_impl.h"
 
 #include "ppapi/c/pp_size.h"
 #include "ppapi/shared_impl/ppb_audio_config_shared.h"
 #include "ppapi/shared_impl/private/ppb_browser_font_trusted_shared.h"
 #include "ppapi/shared_impl/ppb_input_event_shared.h"
@@ skipping 164 matching lines @@
   return (new PPB_HostResolver_Private_Impl(instance))->GetReference();
 }
 
 PP_Resource ResourceCreationImpl::CreateImageData(PP_Instance instance,
                                                   PP_ImageDataFormat format,
                                                   const PP_Size& size,
                                                   PP_Bool init_to_zero) {
   return PPB_ImageData_Impl::Create(instance, format, size, init_to_zero);
 }
 
+PP_Resource ResourceCreationImpl::CreateIMEInputEvent(
+    PP_Instance instance,
+    PP_InputEvent_Type type,
+    PP_TimeTicks time_stamp,
+    struct PP_Var text,
+    uint32_t segment_number,
+    const uint32_t* segment_offsets,
+    int32_t target_segment,
+    uint32_t selection_start,
+    uint32_t selection_end) {
+  if (type != PP_INPUTEVENT_TYPE_IME_COMPOSITION_START &&

[yzshen1, 2012/05/15 18:03:48]

Please put the implementation in ppb_input_event_shared, so that you can use it
in here and resource_creation_proxy.cc.

[kinaba, 2012/05/16 10:13:57]

Done. I also did the refactoring for other input events than IME, but if there's
a particular reason not to do so I'll revert it.

[yzshen1, 2012/05/16 20:33:28]

I don't know of any reason not to do that.
Thanks!
On 2012/05/16 10:13:57, kinaba wrote:

+      type != PP_INPUTEVENT_TYPE_IME_COMPOSITION_UPDATE &&
+      type != PP_INPUTEVENT_TYPE_IME_COMPOSITION_END &&
+      type != PP_INPUTEVENT_TYPE_IME_TEXT)
+    return 0;
+
+  InputEventData data;
+  data.event_type = type;
+  data.event_time_stamp = time_stamp;
+  if (text.type == PP_VARTYPE_STRING) {
+    StringVar* text_str = StringVar::FromPPVar(text);
+    if (!text_str)
+      return 0;
+    data.character_text = text_str->value();
+  }
+  data.composition_target_segment = target_segment;
+  if (segment_number != 0) {
+    data.composition_segment_offsets.assign(&segment_offsets[0],
+                                            &segment_offsets[segment_number+1]);
+  }
+  data.composition_selection_start = selection_start;
+  data.composition_selection_end = selection_end;
+
+  return (new PPB_InputEvent_Shared(::ppapi::OBJECT_IS_IMPL,
+                                    instance, data))->GetReference();
+}
+
 PP_Resource ResourceCreationImpl::CreateKeyboardInputEvent(
     PP_Instance instance,
     PP_InputEvent_Type type,
     PP_TimeTicks time_stamp,
     uint32_t modifiers,
     uint32_t key_code,
     struct PP_Var character_text) {
   if (type != PP_INPUTEVENT_TYPE_RAWKEYDOWN &&
       type != PP_INPUTEVENT_TYPE_KEYDOWN &&
       type != PP_INPUTEVENT_TYPE_KEYUP &&
@@ skipping 147 matching lines @@
                                     instance, data))->GetReference();
 }
 
 PP_Resource ResourceCreationImpl::CreateX509CertificatePrivate(
     PP_Instance instance) {
   return PPB_X509Certificate_Private_Impl::CreateResource(instance);
 }
 
 }  // namespace ppapi
 }  // namespace webkit