No longer keep a lingering reference to TypedUrlDataTypeController after PSS exits

chrome/browser/sync/glue/typed_url_data_type_controller.h

Index: chrome/browser/sync/glue/typed_url_data_type_controller.h
diff --git a/chrome/browser/sync/glue/typed_url_data_type_controller.h b/chrome/browser/sync/glue/typed_url_data_type_controller.h
index 11145d2727d44ba604dc4e0e136cd1c28107bb5b..411dca54b0a49bc5ca6b14f57967716776219a8e 100644
--- a/chrome/browser/sync/glue/typed_url_data_type_controller.h
+++ b/chrome/browser/sync/glue/typed_url_data_type_controller.h
@@ -45,15 +45,9 @@ class TypedUrlDataTypeController : public NonFrontendDataTypeController,
                        const content::NotificationSource& source,
                        const content::NotificationDetails& details) OVERRIDE;
 
-  // CancelableRequestConsumerBase implementation.
-  virtual void OnRequestAdded(CancelableRequestProvider* provider,
-                              CancelableRequestProvider::Handle handle) {}
-  virtual void OnRequestRemoved(CancelableRequestProvider* provider,
-                                CancelableRequestProvider::Handle handle) {}
-  virtual void WillExecute(CancelableRequestProvider* provider,
-                           CancelableRequestProvider::Handle handle) {}
-  virtual void DidExecute(CancelableRequestProvider* provider,
-                          CancelableRequestProvider::Handle handle) {}
+  // Invoked on the history thread to set our history backend - must be called
+  // before CreateSyncComponents() is invoked.
+  void SetBackend(history::HistoryBackend* backend);
 
  protected:
   // NonFrontendDataTypeController interface.
@@ -66,12 +60,7 @@ class TypedUrlDataTypeController : public NonFrontendDataTypeController,
  private:
   virtual ~TypedUrlDataTypeController();
 
-  // Used by PostTaskOnBackendThread().
-  void RunTaskOnBackendThread(const base::Closure& task,
-                              history::HistoryBackend* backend);
-
   history::HistoryBackend* backend_;
-  scoped_refptr<HistoryService> history_service_;
   content::NotificationRegistrar notification_registrar_;
   PrefChangeRegistrar pref_registrar_;

[Nicolas Zea, 2012/05/16 22:40:58]

To some extent, I kind of feel like it's a bug for PrefChangeRegistrar to be
using raw pointers instead of WeakPointers in the first place, which I believe
was where the crash came from.