content/browser/renderer_host/media/video_capture_host.h - Issue 10391065: handle the case when device is closed before media pipeline is fully initialized.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/video_capture_host.h

Issue 10391065: handle the case when device is closed before media pipeline is fully initialized. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: code review Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/media/video_capture_controller_unittest.cc ('K') | « content/browser/renderer_host/media/video_capture_controller_unittest.cc ('k') | content/browser/renderer_host/media/video_capture_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/media/video_capture_host.h

===================================================================

--- content/browser/renderer_host/media/video_capture_host.h (revision 138673)

+++ content/browser/renderer_host/media/video_capture_host.h (working copy)

@@ -78,6 +78,7 @@

int width,

int height,

int frame_per_second) OVERRIDE;

+ virtual void OnPaused(const VideoCaptureControllerID& id) OVERRIDE;

virtual void OnReadyToDelete(const VideoCaptureControllerID& id) OVERRIDE;

private:

@@ -137,6 +138,8 @@

// Handle error coming from VideoCaptureDevice.

void DoHandleError(int device_id);

+ void DoPaused(int device_id);

mflodman_chromium_OOO 2012/05/29 09:11:03 Do we want a comment it should be called on IO-thr

wjia(left Chromium) 2012/05/29 16:59:14 All Do* functions have been renamed to DO*OnIOThre

mflodman_chromium_OOO 2012/05/29 18:19:54 Nice!

// Helpers.

media_stream::VideoCaptureManager* GetVideoCaptureManager();