content/browser/renderer_host/media/video_capture_controller.cc - Issue 10391065: handle the case when device is closed before media pipeline is fully initialized.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/video_capture_controller.cc

Issue 10391065: handle the case when device is closed before media pipeline is fully initialized. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: rebase Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/renderer_host/media/video_capture_controller_event_handler.h » ('j') | content/renderer/media/capture_video_decoder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/media/video_capture_controller.cc

===================================================================

--- content/browser/renderer_host/media/video_capture_controller.cc (revision 137680)

+++ content/browser/renderer_host/media/video_capture_controller.cc (working copy)

@@ -215,8 +215,10 @@

if (!client)

client = FindClient(session_id, controller_clients_);

- if (client)

+ if (client) {

client->session_closed = true;

+ client->event_handler->OnPaused(client->controller_id);

Ronghua Wu (Left Chromium) 2012/05/17 22:54:37 Should we call this be called OnStop?

wjia(left Chromium) 2012/05/23 18:46:48 |Stop| has been used StopCapture. |Pause| is used

+ }

}

void VideoCaptureController::ReturnBuffer(