Scaffolding for an experimental discovery API letting users inject links in the recommended pane of…

chrome/browser/extensions/api/discovery/extension_suggested_link.h

Index: chrome/browser/extensions/api/discovery/extension_suggested_link.h
diff --git a/chrome/browser/extensions/api/discovery/extension_suggested_link.h b/chrome/browser/extensions/api/discovery/extension_suggested_link.h
new file mode 100644
index 0000000000000000000000000000000000000000..2365972a67dea43536a1f5039f41a742e31e978f
--- /dev/null
+++ b/chrome/browser/extensions/api/discovery/extension_suggested_link.h
@@ -0,0 +1,38 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_EXTENSIONS_API_DISCOVERY_EXTENSION_SUGGESTED_LINK_H_
+#define CHROME_BROWSER_EXTENSIONS_API_DISCOVERY_EXTENSION_SUGGESTED_LINK_H_
+#pragma once
+
+#include <string>
+#include <vector>
+
+#include "base/memory/linked_ptr.h"
+
+// ExtensionSuggestedLinks contains a list of scored links that the extension
+// wants to inject in the NTP's recommended pane.
+class ExtensionSuggestedLink {

[Aaron Boodman, 2012/05/15 00:07:43]

This class should be extensions::SuggestedLink, not ExtensionSuggestedLink. You
can also rename the file to just suggested_link.h.

[beaudoin, 2012/05/16 16:56:16]

Done.

+ public:
+  ExtensionSuggestedLink(const std::string& link_url_,
+      const std::string& link_text_, double score);

[Aaron Boodman, 2012/05/15 00:07:43]

Indent doesn't seem right. I think it is supposed to line up with the first
param, and each param should be on its own line in declarations.

[beaudoin, 2012/05/16 16:56:16]

I've been doing too much JavaScript. :)

Done.

+  ~ExtensionSuggestedLink();
+
+  std::string link_url() const { return link_url_; }

[Aaron Boodman, 2012/05/15 00:07:43]

Return type should be const ref.

[beaudoin, 2012/05/16 16:56:16]

Done.

+  std::string link_text() const { return link_text_; }
+  double score() const { return score_; }
+
+ private:
+  std::string link_url_;
+  std::string link_text_;
+  double score_;
+
+  DISALLOW_COPY_AND_ASSIGN(ExtensionSuggestedLink);
+};
+
+// A list of ExtensionSuggestedLink's.
+typedef std::vector<linked_ptr<ExtensionSuggestedLink> >

[Aaron Boodman, 2012/05/15 00:07:43]

It usually ends up making more sense to define these typedefs where they are
used.

[beaudoin, 2012/05/16 16:56:16]

Done.

+    ExtensionSuggestedLinkList;
+
+#endif  // CHROME_BROWSER_EXTENSIONS_API_DISCOVERY_EXTENSION_SUGGESTED_LINK_H_