Scaffolding for an experimental discovery API letting users inject links in the recommended pane of…

chrome/browser/extensions/api/discovery/extension_suggested_links_manager.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_EXTENSIONS_API_DISCOVERY_EXTENSION_SUGGESTED_LINKS_MANAGER_H_
+#define CHROME_BROWSER_EXTENSIONS_API_DISCOVERY_EXTENSION_SUGGESTED_LINKS_MANAGER_H_
+#pragma once
+
+#include <map>
+
+#include "chrome/browser/extensions/api/discovery/extension_suggested_link.h"
+#include "chrome/browser/profiles/profile_keyed_service.h"
+#include "content/public/browser/browser_thread.h"
+
+// This class keeps track of links suggested by an extension using the discovery
+// API.
+class ExtensionSuggestedLinksManager

[Aaron Boodman, 2012/05/15 00:07:43]

extensions::SuggestedLinkManager. Also rename file to suggested_link_manager.h.

Also, I have kind of an aversion to classes called 'Manager', because they are
so general.

What about SuggestedLinkRegistry?

[beaudoin, 2012/05/16 16:56:16]

Done.

+    : public ProfileKeyedService {
+ public:
+  ExtensionSuggestedLinksManager();
+
+  // Takes ownership of |item| in all cases.
+  void Add(const std::string& extension_id, ExtensionSuggestedLink* item);

[Aaron Boodman, 2012/05/15 00:07:43]

You can declare item as scoped_ptr<ExtensionSuggestedLink> item to enforce the
ownership transfer.

[beaudoin, 2012/05/16 16:56:16]

Not sure I did that correctly, in particular I'm not 100% clear on the
difference between .Pass() and .release(). More info welcome! :)

Done.

[Aaron Boodman, 2012/05/17 00:05:29]

release() is appropriate here. Pass() is for when you want to transfer ownership
between two scoped pointers. If you tried to use Pass() here, the compiler would
tell you you were wrong anyway, because the result of Pass() is scoped_ptr<T>.

+
+  const ExtensionSuggestedLinkList* GetAll(

[Aaron Boodman, 2012/05/15 00:07:43]

Comment.

[beaudoin, 2012/05/16 16:56:16]

Done.

+      const std::string& extension_id) const;
+
+  void Clear(const std::string& extension_id, const std::string& linkUrl);

[Aaron Boodman, 2012/05/15 00:07:43]

Comment.

[Aaron Boodman, 2012/05/15 00:07:43]

link_url

[beaudoin, 2012/05/16 16:56:16]

Done.

[beaudoin, 2012/05/16 16:56:16]

Done.

+
+  // Clears all suggested links for |extension_id|.
+  void ClearAll(const std::string& extension_id);
+
+ private:
+  // Maps extension id to a list of notifications for that extension.
+  typedef std::map<std::string, ExtensionSuggestedLinkList> SuggestedLinksMap;
+
+  virtual ~ExtensionSuggestedLinksManager();
+
+  // Gets suggested links for a given extension id.
+  ExtensionSuggestedLinkList& GetAllInternal(const std::string& extension_id);
+
+  SuggestedLinksMap suggested_links_;
+
+  DISALLOW_COPY_AND_ASSIGN(ExtensionSuggestedLinksManager);
+};
+
+#endif  // CHROME_BROWSER_EXTENSIONS_API_DISCOVERY_EXTENSION_SUGGESTED_LINKS_MANAGER_H_