Notify all active login prompts when one login prompt is submitted. This allo...

Notify all active login prompts when one login prompt is submitted. This allows
identical login prompts to dismiss themselves.

BUG=8914
TEST=ui_tests --gtest_filter=LoginPromptTest*

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42770

[tonyg, 2010-03-25 00:13:16]

Hi Elliot,

Are you still the right person to review this? The goal here is to avoid forcing
users to enter their credentials multiple times.

Thanks,
Tony

[Paweł Hajdan Jr., 2010-03-25 07:26:10]

Drive-by with minor test comments.

http://codereview.chromium.org/1039004/diff/20001/17007
File chrome/browser/login_prompt_uitest.cc (right):

http://codereview.chromium.org/1039004/diff/20001/17007#newcode184
chrome/browser/login_prompt_uitest.cc:184: scoped_refptr<TabProxy>
basic_tab1(GetActiveTab());
Please add ASSERT_TRUE(basic_tab1.get()) to avoid crashing entire ui_tests in
case of failure.

http://codereview.chromium.org/1039004/diff/20001/17007#newcode188
chrome/browser/login_prompt_uitest.cc:188: scoped_refptr<TabProxy>
basic_tab2(GetActiveTab());
Same here.

http://codereview.chromium.org/1039004/diff/20001/17007#newcode214
chrome/browser/login_prompt_uitest.cc:214: scoped_refptr<TabProxy>
basic_tab1(GetActiveTab());
Same here.

http://codereview.chromium.org/1039004/diff/20001/17007#newcode218
chrome/browser/login_prompt_uitest.cc:218: scoped_refptr<TabProxy>
basic_tab2(GetActiveTab());
Same here.

[tonyg, 2010-03-25 15:52:45]

http://codereview.chromium.org/1039004/diff/20001/17007
File chrome/browser/login_prompt_uitest.cc (right):

http://codereview.chromium.org/1039004/diff/20001/17007#newcode184
chrome/browser/login_prompt_uitest.cc:184: scoped_refptr<TabProxy>
basic_tab1(GetActiveTab());
On 2010/03/25 07:26:10, Paweł Hajdan Jr. wrote:
> Please add ASSERT_TRUE(basic_tab1.get()) to avoid crashing entire ui_tests in
> case of failure.

Done.

http://codereview.chromium.org/1039004/diff/20001/17007#newcode188
chrome/browser/login_prompt_uitest.cc:188: scoped_refptr<TabProxy>
basic_tab2(GetActiveTab());
On 2010/03/25 07:26:10, Paweł Hajdan Jr. wrote:
> Same here.

Done.

http://codereview.chromium.org/1039004/diff/20001/17007#newcode214
chrome/browser/login_prompt_uitest.cc:214: scoped_refptr<TabProxy>
basic_tab1(GetActiveTab());
On 2010/03/25 07:26:10, Paweł Hajdan Jr. wrote:
> Same here.

Done.

http://codereview.chromium.org/1039004/diff/20001/17007#newcode218
chrome/browser/login_prompt_uitest.cc:218: scoped_refptr<TabProxy>
basic_tab2(GetActiveTab());
On 2010/03/25 07:26:10, Paweł Hajdan Jr. wrote:
> Same here.

Done.

[Paweł Hajdan Jr., 2010-03-25 15:58:35]

Code I commented in the drive-by now LGTM.

[Elliot Glaysher, 2010-03-25 16:57:59]

LGTM. This looks like should work though I haven't touched this part of the code
in a while.