Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1502)

Unified Diff: media/filters/audio_renderer_algorithm.h

Issue 10389138: Remove media::AudioRendererImpl::SignalEndOfStream() and some other minor cleanup. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src
Patch Set: canfillbuffer Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/filters/audio_renderer_algorithm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/audio_renderer_algorithm.h
diff --git a/media/filters/audio_renderer_algorithm.h b/media/filters/audio_renderer_algorithm.h
index 9c0543bece23fa422e1cc3e9cfbc0c30b10b379a..933be82c3c88b662b782cfc4b51903e0584fb9a7 100644
--- a/media/filters/audio_renderer_algorithm.h
+++ b/media/filters/audio_renderer_algorithm.h
@@ -75,8 +75,9 @@ class MEDIA_EXPORT AudioRendererAlgorithm {
float playback_rate() const { return playback_rate_; }
void SetPlaybackRate(float new_rate);
- // Returns whether the algorithm needs more data to continue filling buffers.
- bool NeedsMoreData();
+ // Returns whether the algorithm has enough data at the current playback rate
+ // such that it can write data on the next call to FillBuffer().
+ bool CanFillBuffer();
scherkus (not reviewing) 2012/05/19 03:13:08 NOTE: logic was reversed here so please double che
// Returns true if |audio_buffer_| is at or exceeds capacity.
bool IsQueueFull();
@@ -99,9 +100,6 @@ class MEDIA_EXPORT AudioRendererAlgorithm {
bool is_muted() { return muted_; }
private:
- // Returns true if |audio_buffer_| is empty.
- bool IsQueueEmpty();
-
// Fills |dest| with one frame of audio data at normal speed. Returns true if
// a frame was rendered, false otherwise.
bool OutputNormalPlayback(uint8* dest);
« no previous file with comments | « no previous file | media/filters/audio_renderer_algorithm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698