Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Unified Diff: sync/syncable/syncable.cc

Issue 10389103: Sync: Clear IS_UNSYNCED for deleted local items (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/syncable/syncable.cc
diff --git a/sync/syncable/syncable.cc b/sync/syncable/syncable.cc
index 760a3314a40bef6e12d9aa191cde77925235322e..6092dc2541ffee0b687d74687c7b39761e4016c3 100644
--- a/sync/syncable/syncable.cc
+++ b/sync/syncable/syncable.cc
@@ -1736,6 +1736,13 @@ bool MutableEntry::PutIsDel(bool is_del) {
if (!UnlinkFromOrder()) {
return false;
}
+ // If this item was deleted before it hit the server, we know that no one
+ // will attempt to undelete it. It's never going to make it to the server
Nicolas Zea 2012/05/11 23:21:25 "no one will attempt to undelete it" seems a bit m
rlarocque 2012/05/15 00:41:55 Will do. I was thinking mainly of bookmarks when
+ // either. Mark it as unsynced so we can drop it later in
Nicolas Zea 2012/05/11 23:21:25 Mark it as unsynced -> Unmark it as unsynced
+ // DropDeletedEntries(). See also: crbug.com/125381.
+ if (!Get(ID).ServerKnows()) {
+ Put(IS_UNSYNCED, false);
+ }
}
{

Powered by Google App Engine
This is Rietveld 408576698