Issue 10389101: Change #include <memory.h> to #include <string.h>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10389101: Change #include <memory.h> to #include <string.h> (Closed)

Created:
8 years, 7 months ago by bbudge

Modified:
8 years, 7 months ago

Reviewers:
Mark Seaborn, brettw

CC:
chromium-reviews

Base URL:
http://google-url.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Change #include <memory.h> to #include <string.h> BUG=none TEST=none This allows the file to build with the NaCl toolchain.

Patch Set 1 #

Total comments: 1

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/url_canon.h	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

brettw

Checked in as googleurl@175. I did not roll deps into Chrome, you'll have to do ...

8 years, 7 months ago (2012-05-11 21:24:51 UTC) #3

Mark Seaborn

8 years, 7 months ago (2012-05-11 21:28:41 UTC) #4

http://codereview.chromium.org/10389101/diff/1/src/url_canon.h
File src/url_canon.h (right):

http://codereview.chromium.org/10389101/diff/1/src/url_canon.h#newcode32
src/url_canon.h:32: #include <string.h>
Minor nit: dmichael pointed out that this leaves the #includes unsorted

Expand Messages | Collapse Messages