ui/views/controls/combobox/native_combobox_views.cc - Issue 10389035: Do not consume an ET_KEY_RELEASED event in NativeTextfieldViews and NativeComboboxViews

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/combobox/native_combobox_views.cc

Issue 10389035: Do not consume an ET_KEY_RELEASED event in NativeTextfieldViews and NativeComboboxViews (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/controls/combobox/native_combobox_views.cc

diff --git a/ui/views/controls/combobox/native_combobox_views.cc b/ui/views/controls/combobox/native_combobox_views.cc

index 40c05b724acbdcd8eaf2aead2110f34c1d008160..1a538c80b2ade2812a8f037350876cef8f15fd84 100644

--- a/ui/views/controls/combobox/native_combobox_views.cc

+++ b/ui/views/controls/combobox/native_combobox_views.cc

@@ -221,7 +221,7 @@ bool NativeComboboxViews::HandleKeyPressed(const KeyEvent& e) {

}

bool NativeComboboxViews::HandleKeyReleased(const KeyEvent& e) {

- return true;

+ return false; // crbug.com/127520

}

void NativeComboboxViews::HandleFocus() {

« no previous file with comments | « no previous file | ui/views/controls/textfield/native_textfield_views.cc » ('j') | ui/views/controls/textfield/native_textfield_views.cc » ('J')