chrome/browser/resources/ntp4/other_sessions.js - Issue 10389016: Use hidden attribute rather the 'display: none' for hiding menus.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/ntp4/other_sessions.js

Issue 10389016: Use hidden attribute rather the 'display: none' for hiding menus. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/ntp4/other_sessions.js

diff --git a/chrome/browser/resources/ntp4/other_sessions.js b/chrome/browser/resources/ntp4/other_sessions.js

index b6af33bcde9d3ef9bae385a1fd1a9c4d2a960bef..f9122f98776cb26e33903c158c7e09bcd70e814e 100644

--- a/chrome/browser/resources/ntp4/other_sessions.js

+++ b/chrome/browser/resources/ntp4/other_sessions.js

@@ -55,7 +55,6 @@ cr.define('ntp', function() {

// Create the context menu that appears when the user right clicks

// on a device name.

this.deviceContextMenu_ = DeviceContextMenuController.getInstance().menu;

- this.deviceContextMenu_.style.display = 'none';

document.body.appendChild(this.deviceContextMenu_);

this.promoMessage_ = $('other-sessions-promo-template').cloneNode(true);

@@ -107,7 +106,7 @@ cr.define('ntp', function() {

hideMenu: function() {

// Don't hide if the device context menu is currently showing.

- if (this.deviceContextMenu_.style.display == 'none')

+ if (this.deviceContextMenu_.hidden)

MenuButton.prototype.hideMenu.call(this);