Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Unified Diff: chrome/browser/download/download_browsertest.cc

Issue 10388252: Refactoring ExtenionInstallUI to abstract the Browser references. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Minor clean-ups Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_browsertest.cc
diff --git a/chrome/browser/download/download_browsertest.cc b/chrome/browser/download/download_browsertest.cc
index 097c951b66db48f33eee8a9bbf0ae493a55a5d15..52d3fa002e4cc7c0f36c18a4c19acc626ec42c02 100644
--- a/chrome/browser/download/download_browsertest.cc
+++ b/chrome/browser/download/download_browsertest.cc
@@ -28,7 +28,7 @@
#include "chrome/browser/download/download_shelf.h"
#include "chrome/browser/download/download_test_observer.h"
#include "chrome/browser/download/download_util.h"
-#include "chrome/browser/extensions/extension_install_ui.h"
+#include "chrome/browser/extensions/extension_install_prompt.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/history/history.h"
#include "chrome/browser/net/url_request_mock_util.h"
@@ -155,9 +155,9 @@ class DownloadsHistoryDataCollector {
// Mock that simulates a permissions dialog where the user denies
// permission to install. TODO(skerner): This could be shared with
// extensions tests. Find a common place for this class.
-class MockAbortExtensionInstallUI : public ExtensionInstallUI {
+class MockAbortExtensionInstallPrompt : public ExtensionInstallPrompt {
public:
- MockAbortExtensionInstallUI() : ExtensionInstallUI(NULL) {}
+ MockAbortExtensionInstallPrompt() : ExtensionInstallPrompt(NULL) {}
// Simulate a user abort on an extension installation.
virtual void ConfirmInstall(Delegate* delegate, const Extension* extension) {
@@ -171,10 +171,10 @@ class MockAbortExtensionInstallUI : public ExtensionInstallUI {
// Mock that simulates a permissions dialog where the user allows
// installation.
-class MockAutoConfirmExtensionInstallUI : public ExtensionInstallUI {
+class MockAutoConfirmExtensionInstallPrompt : public ExtensionInstallPrompt {
public:
- explicit MockAutoConfirmExtensionInstallUI(Profile* profile)
- : ExtensionInstallUI(profile) {}
+ explicit MockAutoConfirmExtensionInstallPrompt(Profile* profile)
+ : ExtensionInstallPrompt(profile) {}
// Proceed without confirmation prompt.
virtual void ConfirmInstall(Delegate* delegate, const Extension* extension) {
@@ -1689,8 +1689,8 @@ IN_PROC_BROWSER_TEST_F(DownloadTest, CrxInstallDenysPermissions) {
// Install a mock install UI that simulates a user denying permission to
// finish the install.
- download_crx_util::SetMockInstallUIForTesting(
- new MockAbortExtensionInstallUI());
+ download_crx_util::SetMockInstallPromptForTesting(
+ new MockAbortExtensionInstallPrompt());
scoped_ptr<DownloadTestObserver> observer(
DangerousDownloadWaiter(
@@ -1722,8 +1722,8 @@ IN_PROC_BROWSER_TEST_F(DownloadTest, CrxInstallAcceptPermissions) {
// Install a mock install UI that simulates a user allowing permission to
// finish the install.
- download_crx_util::SetMockInstallUIForTesting(
- new MockAutoConfirmExtensionInstallUI(browser()->profile()));
+ download_crx_util::SetMockInstallPromptForTesting(
+ new MockAutoConfirmExtensionInstallPrompt(browser()->profile()));
scoped_ptr<DownloadTestObserver> observer(
DangerousDownloadWaiter(
@@ -1753,8 +1753,8 @@ IN_PROC_BROWSER_TEST_F(DownloadTest, CrxInvalid) {
// Install a mock install UI that simulates a user allowing permission to
// finish the install, and dismisses any error message. We check that the
// install failed below.
- download_crx_util::SetMockInstallUIForTesting(
- new MockAutoConfirmExtensionInstallUI(browser()->profile()));
+ download_crx_util::SetMockInstallPromptForTesting(
+ new MockAutoConfirmExtensionInstallPrompt(browser()->profile()));
scoped_ptr<DownloadTestObserver> observer(
DangerousDownloadWaiter(
@@ -1781,8 +1781,8 @@ IN_PROC_BROWSER_TEST_F(DownloadTest, CrxLargeTheme) {
// Install a mock install UI that simulates a user allowing permission to
// finish the install.
- download_crx_util::SetMockInstallUIForTesting(
- new MockAutoConfirmExtensionInstallUI(browser()->profile()));
+ download_crx_util::SetMockInstallPromptForTesting(
+ new MockAutoConfirmExtensionInstallPrompt(browser()->profile()));
scoped_ptr<DownloadTestObserver> observer(
DangerousDownloadWaiter(

Powered by Google App Engine
This is Rietveld 408576698