chrome/browser/extensions/api/permissions/permissions_api.cc - Issue 10388252: Refactoring ExtenionInstallUI to abstract the Browser references.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/permissions/permissions_api.cc

Issue 10388252: Refactoring ExtenionInstallUI to abstract the Browser references. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed Yoyo's comments. Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/permissions/permissions_api.cc

diff --git a/chrome/browser/extensions/api/permissions/permissions_api.cc b/chrome/browser/extensions/api/permissions/permissions_api.cc

index 2c2f391a9167be2c8435cbc0c8250316d0f9c35a..0af5db573e64418066edfa17ff314f52316ae11d 100644

--- a/chrome/browser/extensions/api/permissions/permissions_api.cc

+++ b/chrome/browser/extensions/api/permissions/permissions_api.cc

@@ -203,7 +203,7 @@ bool RequestPermissionsFunction::RunImpl() {

InstallUIAbort(true);

} else {

CHECK_EQ(DO_NOT_SKIP, auto_confirm_for_tests);

- install_ui_.reset(new ExtensionInstallUI(profile()));

+ install_ui_.reset(new ExtensionInstallPrompt(profile()));

install_ui_->ConfirmPermissions(

this, GetExtension(), requested_permissions_.get());

}