Refactoring ExtenionInstallUI to abstract the Browser references.

chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_unittest.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/compiler_specific.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/json/json_file_value_serializer.h"
 #import "base/memory/scoped_nsobject.h"
 #include "base/path_service.h"
 #include "base/sys_string_conversions.h"
 #include "base/utf_string_conversions.h"
 #include "base/values.h"
-#import "chrome/browser/extensions/extension_install_ui.h"
+#import "chrome/browser/extensions/extension_install_prompt.h"
 #include "chrome/browser/ui/cocoa/cocoa_profile_test.h"
 #import "chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/extensions/extension.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #import "testing/gtest_mac.h"
 #include "testing/platform_test.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "ui/gfx/image/image.h"
 #include "webkit/glue/image_decoder.h"
@@ skipping 44 matching lines @@
       return;
     }
   }
 
   FilePath test_data_dir_;
   gfx::Image icon_;
   scoped_refptr<Extension> extension_;
 };
 
 
-// Mock out the ExtensionInstallUI::Delegate interface so we can ensure the
+// Mock out the ExtensionInstallPrompt::Delegate interface so we can ensure the
 // dialog is interacting with it correctly.
-class MockExtensionInstallUIDelegate : public ExtensionInstallUI::Delegate {
+class MockExtensionInstallPromptDelegate
+    : public ExtensionInstallPrompt::Delegate {
  public:
-  MockExtensionInstallUIDelegate()
+  MockExtensionInstallPromptDelegate()
       : proceed_count_(0),
         abort_count_(0) {}
 
-  // ExtensionInstallUI::Delegate overrides.
+  // ExtensionInstallPrompt::Delegate overrides.
   virtual void InstallUIProceed() OVERRIDE {
     proceed_count_++;
   }
 
   virtual void InstallUIAbort(bool user_initiated) OVERRIDE {
     abort_count_++;
   }
 
   int proceed_count() { return proceed_count_; }
   int abort_count() { return abort_count_; }
 
  protected:
   int proceed_count_;
   int abort_count_;
 };
 
 // Test that we can load the two kinds of prompts correctly, that the outlets
 // are hooked up, and that the dialog calls cancel when cancel is pressed.
 TEST_F(ExtensionInstallDialogControllerTest, BasicsNormalCancel) {
-  MockExtensionInstallUIDelegate delegate;
+  MockExtensionInstallPromptDelegate delegate;
 
-  ExtensionInstallUI::Prompt prompt(ExtensionInstallUI::INSTALL_PROMPT);
+  ExtensionInstallPrompt::Prompt prompt(ExtensionInstallPrompt::INSTALL_PROMPT);
   std::vector<string16> permissions;
   permissions.push_back(UTF8ToUTF16("warning 1"));
   prompt.SetPermissions(permissions);
   prompt.set_extension(extension_.get());
   prompt.set_icon(icon_);
 
   scoped_nsobject<ExtensionInstallDialogController>
     controller([[ExtensionInstallDialogController alloc]
                  initWithParentWindow:test_window()
                               profile:profile()
@@ skipping 32 matching lines @@
   EXPECT_NE('^', [[[controller okButton] stringValue] characterAtIndex:0]);
 
   // Test that cancel calls our delegate.
   [controller cancel:nil];
   EXPECT_EQ(1, delegate.abort_count());
   EXPECT_EQ(0, delegate.proceed_count());
 }
 
 
 TEST_F(ExtensionInstallDialogControllerTest, BasicsNormalOK) {
-  MockExtensionInstallUIDelegate delegate;
+  MockExtensionInstallPromptDelegate delegate;
 
-  ExtensionInstallUI::Prompt prompt(ExtensionInstallUI::INSTALL_PROMPT);
+  ExtensionInstallPrompt::Prompt prompt(
+      ExtensionInstallPrompt::INSTALL_PROMPT);
   std::vector<string16> permissions;
   permissions.push_back(UTF8ToUTF16("warning 1"));
   prompt.SetPermissions(permissions);
   prompt.set_extension(extension_.get());
   prompt.set_icon(icon_);
 
   scoped_nsobject<ExtensionInstallDialogController>
   controller([[ExtensionInstallDialogController alloc]
                initWithParentWindow:test_window()
                             profile:profile()
                            delegate:&delegate
                              prompt:prompt]);
 
   [controller window];  // force nib load
   [controller ok:nil];
 
   EXPECT_EQ(0, delegate.abort_count());
   EXPECT_EQ(1, delegate.proceed_count());
 }
 
 // Test that controls get repositioned when there are two warnings vs one
 // warning.
 TEST_F(ExtensionInstallDialogControllerTest, MultipleWarnings) {
-  MockExtensionInstallUIDelegate delegate1;
-  MockExtensionInstallUIDelegate delegate2;
+  MockExtensionInstallPromptDelegate delegate1;
+  MockExtensionInstallPromptDelegate delegate2;
 
-  ExtensionInstallUI::Prompt one_warning_prompt(
-      ExtensionInstallUI::INSTALL_PROMPT);
+  ExtensionInstallPrompt::Prompt one_warning_prompt(
+      ExtensionInstallPrompt::INSTALL_PROMPT);
   std::vector<string16> permissions;
   permissions.push_back(UTF8ToUTF16("warning 1"));
   one_warning_prompt.SetPermissions(permissions);
   one_warning_prompt.set_extension(extension_.get());
   one_warning_prompt.set_icon(icon_);
 
-  ExtensionInstallUI::Prompt two_warnings_prompt(
-      ExtensionInstallUI::INSTALL_PROMPT);
+  ExtensionInstallPrompt::Prompt two_warnings_prompt(
+      ExtensionInstallPrompt::INSTALL_PROMPT);
   permissions.push_back(UTF8ToUTF16("warning 2"));
   two_warnings_prompt.SetPermissions(permissions);
   two_warnings_prompt.set_extension(extension_.get());
   two_warnings_prompt.set_icon(icon_);
 
   scoped_nsobject<ExtensionInstallDialogController>
   controller1([[ExtensionInstallDialogController alloc]
                 initWithParentWindow:test_window()
                              profile:profile()
                             delegate:&delegate1
@@ skipping 22 matching lines @@
   ASSERT_LT([[controller1 subtitleField] frame].origin.y,
             [[controller2 subtitleField] frame].origin.y);
 
   ASSERT_LT([[controller1 titleField] frame].origin.y,
             [[controller2 titleField] frame].origin.y);
 }
 
 // Test that we can load the skinny prompt correctly, and that the outlets are
 // are hooked up.
 TEST_F(ExtensionInstallDialogControllerTest, BasicsSkinny) {
-  MockExtensionInstallUIDelegate delegate;
+  MockExtensionInstallPromptDelegate delegate;
 
   // No warnings should trigger skinny prompt.
-  ExtensionInstallUI::Prompt no_warnings_prompt(
-      ExtensionInstallUI::INSTALL_PROMPT);
+  ExtensionInstallPrompt::Prompt no_warnings_prompt(
+      ExtensionInstallPrompt::INSTALL_PROMPT);
   no_warnings_prompt.set_extension(extension_.get());
   no_warnings_prompt.set_icon(icon_);
 
   scoped_nsobject<ExtensionInstallDialogController>
   controller([[ExtensionInstallDialogController alloc]
                initWithParentWindow:test_window()
                             profile:profile()
                            delegate:&delegate
                              prompt:no_warnings_prompt]);
 
@@ skipping 20 matching lines @@
   EXPECT_NE('^', [[[controller okButton] stringValue] characterAtIndex:0]);
 
   EXPECT_TRUE([controller subtitleField] == nil);
   EXPECT_TRUE([controller warningsField] == nil);
 }
 
 
 // Test that we can load the inline prompt correctly, and that the outlets are
 // are hooked up.
 TEST_F(ExtensionInstallDialogControllerTest, BasicsInline) {
-  MockExtensionInstallUIDelegate delegate;
+  MockExtensionInstallPromptDelegate delegate;
 
   // No warnings should trigger skinny prompt.
-  ExtensionInstallUI::Prompt inline_prompt(
-      ExtensionInstallUI::INLINE_INSTALL_PROMPT);
+  ExtensionInstallPrompt::Prompt inline_prompt(
+      ExtensionInstallPrompt::INLINE_INSTALL_PROMPT);
   inline_prompt.SetInlineInstallWebstoreData("1,000", 3.5, 200);
   inline_prompt.set_extension(extension_.get());
   inline_prompt.set_icon(icon_);
 
   scoped_nsobject<ExtensionInstallDialogController>
   controller([[ExtensionInstallDialogController alloc]
                initWithParentWindow:test_window()
                             profile:profile()
                            delegate:&delegate
                              prompt:inline_prompt]);
@@ skipping 29 matching lines @@
 
   // Though we have no permissions warnings, these should still be hooked up,
   // just invisible.
   EXPECT_TRUE([controller subtitleField] != nil);
   EXPECT_TRUE([[controller subtitleField] isHidden]);
   EXPECT_TRUE([controller warningsField] != nil);
   EXPECT_TRUE([[controller warningsField] isHidden]);
   EXPECT_TRUE([controller warningsSeparator] != nil);
   EXPECT_TRUE([[controller warningsSeparator] isHidden]);
 }