Refactoring ExtenionInstallUI to abstract the Browser references.

chrome/browser/extensions/extension_webstore_private_api.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_WEBSTORE_PRIVATE_API_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_WEBSTORE_PRIVATE_API_H_
 #pragma once
 
 #include <string>
 
 #include "chrome/browser/extensions/bundle_installer.h"
 #include "chrome/browser/extensions/extension_function.h"
-#include "chrome/browser/extensions/extension_install_ui.h"
+#include "chrome/browser/extensions/extension_install_prompt.h"
 #include "chrome/browser/extensions/webstore_install_helper.h"
 #include "chrome/browser/extensions/webstore_installer.h"
 #include "chrome/common/net/gaia/google_service_auth_error.h"
 #include "content/public/browser/gpu_data_manager_observer.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
 
 class ProfileSyncService;
 
 namespace content {
@@ skipping 42 matching lines @@
   // Reads the extension |details| into |items|.
   bool ReadBundleInfo(base::ListValue* details,
                       extensions::BundleInstaller::ItemList* items);
 
  private:
   scoped_refptr<extensions::BundleInstaller> bundle_;
 };
 
 class BeginInstallWithManifestFunction
     : public AsyncExtensionFunction,
-      public ExtensionInstallUI::Delegate,
+      public ExtensionInstallPrompt::Delegate,
       public WebstoreInstallHelper::Delegate {
  public:
   DECLARE_EXTENSION_FUNCTION_NAME("webstorePrivate.beginInstallWithManifest3");
 
   // Result codes for the return value. If you change this, make sure to
   // update the description for the beginInstallWithManifest3 callback in
   // the extension API JSON.
   enum ResultCode {
     ERROR_NONE = 0,
 
@@ skipping 24 matching lines @@
   // WebstoreInstallHelper::Delegate:
   virtual void OnWebstoreParseSuccess(
       const std::string& id,
       const SkBitmap& icon,
       base::DictionaryValue* parsed_manifest) OVERRIDE;
   virtual void OnWebstoreParseFailure(
       const std::string& id,
       InstallHelperResultCode result_code,
       const std::string& error_message) OVERRIDE;
 
-  // ExtensionInstallUI::Delegate:
+  // ExtensionInstallPrompt::Delegate:
   virtual void InstallUIProceed() OVERRIDE;
   virtual void InstallUIAbort(bool user_initiated) OVERRIDE;
 
  protected:
   virtual ~BeginInstallWithManifestFunction();
 
   // ExtensionFunction:
   virtual bool RunImpl() OVERRIDE;
 
   // Sets the result_ as a string based on |code|.
   void SetResult(ResultCode code);
 
  private:
   // These store the input parameters to the function.
   std::string id_;
   std::string manifest_;
   std::string icon_data_;
   std::string localized_name_;
   bool use_app_installed_bubble_;
 
   // The results of parsing manifest_ and icon_data_ go into these two.
   scoped_ptr<base::DictionaryValue> parsed_manifest_;
   SkBitmap icon_;
 
   // A dummy Extension object we create for the purposes of using
-  // ExtensionInstallUI to prompt for confirmation of the install.
+  // ExtensionInstallPrompt to prompt for confirmation of the install.
   scoped_refptr<extensions::Extension> dummy_extension_;
 
   // The class that displays the install prompt.
-  scoped_ptr<ExtensionInstallUI> install_ui_;
+  scoped_ptr<ExtensionInstallPrompt> install_ui_;

[Yoyo Zhou, 2012/05/23 23:17:49]

nit: rename

[Jay Civelli, 2012/05/30 20:20:35]

Done.

 };
 
 class CompleteInstallFunction : public SyncExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION_NAME("webstorePrivate.completeInstall");
 
  protected:
   virtual ~CompleteInstallFunction() {}
 
   // ExtensionFunction:
@@ skipping 85 matching lines @@
 
  private:
   void CreateResult(bool webgl_allowed);
 
   // A false return value is always valid, but a true one is only valid if full
   // GPU info has been collected in a GPU process.
   static bool IsWebGLAllowed(content::GpuDataManager* manager);
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_WEBSTORE_PRIVATE_API_H_